Forecast reader #204
Merged
Forecast reader #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@coderabbitai summary |
Contributor
Author
|
@coderabbitai review |
strickvl
requested changes
May 15, 2025
Contributor
There was a problem hiding this comment.
I wonder if this image could have a bit more of the zenml dashboard visible just so we reinforce the fact that it's visualizations from within zenml? or a GIF perhaps showing that this is interactive?
Contributor
There was a problem hiding this comment.
Or actually I see you added a GIF below too. Maybe leave it then.
Contributor
There was a problem hiding this comment.
Nothing actionable, but just noting that our DAG visualizer starts to look a bit scruffy when the DAG is complex.
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
strickvl
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New project WIP