Skip to content

Conversation

@stefannica
Copy link
Contributor

Describe changes

Restore the previous behaviour of using the saved_model format
instead of H5 in the Keras model materializer. Aside from preserving
backwards compatibility with previous ZenML versions, this also allows
de-materialized Keras models to be served with Seldon (which has no
support for H5).

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels May 24, 2022
@stefannica stefannica changed the title Bring back served_model as the format used in the keras materializer Bring back the served_model format to the keras materializer May 24, 2022
@stefannica stefannica changed the base branch from main to develop May 24, 2022 08:43
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry that that was breaking

Copy link
Contributor

@safoinme safoinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit! sorry that's my bad actually, I didn't consider that Seldon only accepts saved model format instead of hdf5.

@stefannica stefannica merged commit 51218e5 into develop May 24, 2022
@stefannica stefannica deleted the bug/fix-keras-materializer branch May 24, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal To filter out internal PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants