Making utils more consistent
#658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
enhancement
schustmi
approved these changes
May 30, 2022
bcdurak
requested changes
May 31, 2022
Contributor
bcdurak
left a comment
bcdurak
left a comment
There was a problem hiding this comment.
Everything looks good, great changes! I left a few small comments for improvement.
src/zenml/integrations/tensorflow/materializers/keras_materializer.py
Outdated
Show resolved
Hide resolved
bcdurak
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secrets_manager_utils.pyfromutilsdirectory to thesecrets_managersdirectoryutils.pyfile fromioto the mainutilsdirectory (since it is used in many places in the codebase.Pre-requisites
Please ensure you have done the following:
Types of changes