Skip to content

Fix GCP artifact store #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefannica merged 4 commits into from
Jun 27, 2022
Merged

Fix GCP artifact store #730

stefannica merged 4 commits into from
Jun 27, 2022

Conversation

@schustmi
Copy link
Contributor

@schustmi schustmi commented Jun 27, 2022 •
edited
Loading

Describe changes

  • The GCP artifact store listdir method didn't return a list of strings but dictionaries instead
  • The paths returned by the glob and walk methods didn't include the gs:// prefix

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested review from bcdurak and htahir1 June 27, 2022 14:32
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Jun 27, 2022
bcdurak
bcdurak approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes! Everything looks good!

fa9r
fa9r approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefannica stefannica merged commit e1e48f9 into develop Jun 27, 2022
@stefannica stefannica deleted the bugfix/gcp-artifact-store branch June 27, 2022 17:21
@schustmi schustmi mentioned this pull request Jun 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcdurak bcdurak bcdurak approved these changes

@htahir1 htahir1 Awaiting requested review from htahir1

+1 more reviewer

@fa9r fa9r fa9r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working internal To filter out internal PRs and issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@schustmi @fa9r @bcdurak @stefannica