-
Notifications
You must be signed in to change notification settings - Fork 559
Add zenml stack recipe CLI commands #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
safoinme
reviewed
Jul 28, 2022
safoinme
reviewed
Jul 28, 2022
…enml into misc/add-mlops-stacks
safoinme
reviewed
Jul 28, 2022
AlexejPenner
approved these changes
Aug 17, 2022
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautifully done, love all the usability goodies and clear error/warning messages 🔥
Co-authored-by: Alexej Penner <thealexejpenner@gmail.com>
…enml into misc/add-mlops-stacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Stack Recipes CLI commands
This PR introduces the
zenml stack recipeCLI commands that allow the following functionalities.zenml stack recipe list: List all available stack recipes.zenml stack recipe pull <recipe-name>: Pull a recipe to your local filesystem.zenml stack recipe deploy <recipe-name>: Deploy a specific stack recipe and auto-import the resources created, as a ZenML stack.zenml stack recipe destroy <recipe-name>: Destroy all resources created by a recipe.zenml stack recipe clean: Deletes the pulled recipes from the local filesystem.Extensive error messages are put in place to guide users if the commands fail. This has been done keeping in mind that the feature would be in alpha, and things could break unexpectedly.
Terraform wrapper
A
Terraformclass is implemented as a wrapper around theterraformCLI. It adds the following features:terraforminstalled. Raise an exception and point them to the installation page if they don't have it.applycommand that performs aterraform initand thenterraform applyon the recipe. Theinitis only performed once to save time.destroycommand that performs a simpleterraform destroybut can potentially include a--forceparameter in the future to force deletion of resources. Keeping it out for now, in the absence of tests, to avoid unintended consequences.terraformcommand executions.Features yet to be added:
Minor changes
Pre-requisites
Please ensure you have done the following:
Types of changes