fix: ファイル名にコロンが含まれるケースを考慮 #551
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yktakaha4
commented
Sep 16, 2025
|
|
||
| // e.g. foo:filename => ["foo", "filename"] | ||
| // e.g. foo diff:filename => ["foo diff", "filename"] | ||
| const [langInfo, fileName] = str.split(':'); |
There was a problem hiding this comment.
当初は str.split(':', 2); のような書き方で修正できるかと思ったのですが、そのような仕様ではなかったようなので左端のコロンを探して分割するように修正しました
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/String/split#limit
|
@yktakaha4 ご対応ありがとうございます！「左端のコロンを探して分割する」の方針で良いと思います。マージさせていただきます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
コードブロックにおいて、ファイル名にコロンが含まれるケースを考慮してファイル名を抽出します
html:filename:bar.htmlのような形式でファイル名が指定されていた時に、htmlが拡張子、filename:bar.htmlがファイル名として抽出されるようになります（ローカルのzenn-cliで検証）
Resolves zenn-dev/zenn-community#726
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。