Category: restore management page import flow (dry-run preview + details bottom sheet) #14
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,60 +1,184 @@ | ||||||
| import 'package:flutter/material.dart'; | ||||||
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | ||||||
| import '../../models/category.dart'; | ||||||
| import '../../models/category_template.dart'; | ||||||
| import '../../providers/category_provider.dart'; | ||||||
| import '../../providers/ledger_provider.dart'; | ||||||
| import '../../services/api/category_service.dart'; | ||||||
| import '../../services/api/category_service_integrated.dart'; | ||||||
| import '../../widgets/bottom_sheets/import_details_sheet.dart'; | ||||||
|
|
||||||
| class CategoryManagementEnhancedPage extends ConsumerStatefulWidget { | ||||||
| const CategoryManagementEnhancedPage({super.key}); | ||||||
|
|
||||||
| @override | ||||||
| ConsumerState<CategoryManagementEnhancedPage> createState() => _CategoryManagementEnhancedPageState(); | ||||||
| } | ||||||
|
|
||||||
| class _CategoryManagementEnhancedPageState extends ConsumerState<CategoryManagementEnhancedPage> { | ||||||
| bool _busy = false; | ||||||
|
|
||||||
| @override | ||||||
| Widget build(BuildContext context) { | ||||||
| return Scaffold( | ||||||
| appBar: AppBar( | ||||||
| title: const Text('分类管理'), | ||||||
| actions: [ | ||||||
| IconButton( | ||||||
| tooltip: '从模板库导入', | ||||||
| icon: const Icon(Icons.library_add), | ||||||
| onPressed: _busy ? null : _showTemplateLibrary, | ||||||
| ), | ||||||
| ], | ||||||
| ), | ||||||
| body: Center( | ||||||
| child: _busy | ||||||
| ? const CircularProgressIndicator() | ||||||
| : const Text('分类管理（最小版）：点击右上角导入模板') | ||||||
| ), | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
| Future<void> _showTemplateLibrary() async { | ||||||
| final ledgerId = ref.read(currentLedgerProvider)?.id; | ||||||
| if (ledgerId == null) { | ||||||
| if (!mounted) return; | ||||||
| ScaffoldMessenger.of(context).showSnackBar(const SnackBar(content: Text('无当前账本，无法导入模板'))); | ||||||
| return; | ||||||
| } | ||||||
|
|
||||||
| setState(() { _busy = true; }); | ||||||
| List<SystemCategoryTemplate> templates = []; | ||||||
| try { | ||||||
| templates = await CategoryServiceIntegrated().getAllTemplates(forceRefresh: true); | ||||||
| } catch (_) {} | ||||||
| if (!mounted) return; | ||||||
|
There was a problem hiding this comment. Using For more robust asynchronous operations, consider using a |
||||||
| setState(() { _busy = false; }); | ||||||
|
|
||||||
| final selected = <SystemCategoryTemplate>{}; | ||||||
| String conflict = 'skip'; // skip|rename|update | ||||||
| ImportResult? preview; | ||||||
|
|
||||||
| await showDialog<void>( | ||||||
| context: context, | ||||||
| builder: (ctx) { | ||||||
| return StatefulBuilder( | ||||||
| builder: (ctx, setLocal) => AlertDialog( | ||||||
| title: const Text('从模板库导入'), | ||||||
| content: SizedBox( | ||||||
| width: 480, | ||||||
| child: Column( | ||||||
| mainAxisSize: MainAxisSize.min, | ||||||
| children: [ | ||||||
| Row( | ||||||
| children: [ | ||||||
| const Text('冲突策略: '), | ||||||
| const SizedBox(width: 8), | ||||||
| DropdownButton<String>( | ||||||
| value: conflict, | ||||||
| items: const [ | ||||||
| DropdownMenuItem(value: 'skip', child: Text('跳过')), | ||||||
| DropdownMenuItem(value: 'rename', child: Text('重命名')), | ||||||
| DropdownMenuItem(value: 'update', child: Text('覆盖')), | ||||||
| ], | ||||||
| onChanged: (v) { if (v!=null) setLocal((){ conflict = v; }); }, | ||||||
|
There was a problem hiding this comment. Missing space after 'if' and around '!=' operator. Should be formatted as 'if (v != null)' for consistency with Dart style guidelines.
Suggested change
|
||||||
| ), | ||||||
| ], | ||||||
| ), | ||||||
| const SizedBox(height: 8), | ||||||
| SizedBox( | ||||||
| height: 320, | ||||||
| child: ListView.builder( | ||||||
| itemCount: templates.length, | ||||||
| itemBuilder: (_, i) { | ||||||
| final t = templates[i]; | ||||||
| final checked = selected.contains(t); | ||||||
| return CheckboxListTile( | ||||||
| value: checked, | ||||||
| onChanged: (_) => setLocal((){ | ||||||
| if (checked) { selected.remove(t); } else { selected.add(t); } | ||||||
|
Comment on lines
+98
to
+99
There was a problem hiding this comment. Missing space after 'setLocal' before the opening parenthesis. Should be formatted as 'setLocal(() {' for consistency with Dart formatting standards. |
||||||
| }), | ||||||
| dense: true, | ||||||
| title: Text(t.name), | ||||||
| subtitle: Text(t.classification.name), | ||||||
| ); | ||||||
| }, | ||||||
| ), | ||||||
| ), | ||||||
| if (preview != null) ...[ | ||||||
| const Divider(), | ||||||
| Align( | ||||||
| alignment: Alignment.centerLeft, | ||||||
| child: Text('预览（服务端 dry-run ）', style: Theme.of(context).textTheme.titleSmall), | ||||||
| ), | ||||||
| SizedBox( | ||||||
| height: 160, | ||||||
| child: ListView.builder( | ||||||
| itemCount: preview!.details.length, | ||||||
| itemBuilder: (_, i) { | ||||||
| final d = preview!.details[i]; | ||||||
| final color = (d.action == 'failed' || d.action == 'skipped') ? Colors.orange : Colors.green; | ||||||
|
There was a problem hiding this comment. Hardcoded colors like |
||||||
| return ListTile( | ||||||
| dense: true, | ||||||
| title: Text(d.finalName ?? d.originalName), | ||||||
| subtitle: Text(d.action + (d.reason!=null ? ' (${d.reason})' : '')), | ||||||
| trailing: Icon( | ||||||
| d.action == 'failed' ? Icons.error : (d.action=='skipped'? Icons.warning_amber : Icons.check_circle), | ||||||
| color: color, | ||||||
| ), | ||||||
| ); | ||||||
| }, | ||||||
| ), | ||||||
| ), | ||||||
| ], | ||||||
| ], | ||||||
| ), | ||||||
| ), | ||||||
| actions: [ | ||||||
| TextButton(onPressed: () => Navigator.pop(ctx), child: const Text('取消')), | ||||||
| TextButton( | ||||||
| onPressed: selected.isEmpty ? null : () async { | ||||||
| try { | ||||||
| final items = selected.map((t) => { 'template_id': t.id }).toList(); | ||||||
| final res = await CategoryService().importTemplatesAdvanced( | ||||||
| ledgerId: ledgerId, | ||||||
| items: items, | ||||||
| onConflict: conflict, | ||||||
| dryRun: true, | ||||||
| ); | ||||||
| setLocal((){ preview = res; }); | ||||||
|
There was a problem hiding this comment. Missing space after opening parenthesis. Should be formatted as 'setLocal(() { preview = res; });' for consistency with Dart formatting standards.
Suggested change
|
||||||
| } catch (e) { | ||||||
| if (context.mounted) { | ||||||
| ScaffoldMessenger.of(context).showSnackBar(SnackBar(content: Text('预览失败: $e'))); | ||||||
| } | ||||||
| } | ||||||
| }, | ||||||
| child: const Text('预览'), | ||||||
| ), | ||||||
| FilledButton( | ||||||
| onPressed: (selected.isEmpty) ? null : () async { | ||||||
| Navigator.pop(ctx); | ||||||
| try { | ||||||
| final items = selected.map((t) => { 'template_id': t.id }).toList(); | ||||||
| final result = await CategoryService().importTemplatesAdvanced( | ||||||
| ledgerId: ledgerId, | ||||||
| items: items, | ||||||
| onConflict: conflict, | ||||||
| ); | ||||||
| if (!mounted) return; | ||||||
| await ref.read(userCategoriesProvider.notifier).refreshFromBackend(ledgerId: ledgerId); | ||||||
| await ImportDetailsSheet.show(context, result); | ||||||
| } catch (e) { | ||||||
| if (!mounted) return; | ||||||
| ScaffoldMessenger.of(context).showSnackBar(SnackBar(content: Text('导入失败: $e'))); | ||||||
| } | ||||||
| }, | ||||||
|
Comment on lines
+159
to
+175
There was a problem hiding this comment. When the '确认导入' (Confirm Import) button is pressed, the dialog is closed, and the import process begins. However, the main screen doesn't show a loading indicator because the onPressed: (selected.isEmpty) ? null : () async {
Navigator.pop(ctx);
setState(() { _busy = true; });
try {
final items = selected.map((t) => { 'template_id': t.id }).toList();
final result = await CategoryService().importTemplatesAdvanced(
ledgerId: ledgerId,
items: items,
onConflict: conflict,
);
if (!mounted) return;
await ref.read(userCategoriesProvider.notifier).refreshFromBackend(ledgerId: ledgerId);
await ImportDetailsSheet.show(context, result);
} catch (e) {
if (!mounted) return;
ScaffoldMessenger.of(context).showSnackBar(SnackBar(content: Text('导入失败: $e')));
} finally {
if (mounted) {
setState(() { _busy = false; });
}
}
}, |
||||||
| child: const Text('确认导入'), | ||||||
| ), | ||||||
| ], | ||||||
|
Comment on lines
+137
to
178
There was a problem hiding this comment. The logic to create the To improve maintainability and avoid redundancy, you can extract this logic. A good approach would be to define |
||||||
| ), | ||||||
| ); | ||||||
| }, | ||||||
| ); | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
try-catchblock currently swallows errors silently. If fetching templates fails, the user will be presented with an empty list in the dialog without any explanation, which can be confusing. It's important to provide feedback to the user when an error occurs, for instance, by showing aSnackBar.