chore(api): feature-gate demo endpoints; align CI clippy mode

[zensgit]

Title: chore(api): tighten feature-gating for demo endpoints and align clippy modes

Summary

• Gate demo/placeholder endpoints behind demo_endpoints feature without impacting default build.
• Refactor router construction in main.rs to avoid mut when feature is off.
• Align local CI script with GitHub Actions: cargo check --all-features, then cargo clippy --no-default-features -D warnings.

Changes

• jive-api/src/main.rs: build Router immutably; apply cfg-gated chain to add demo routes when feature enabled.
• jive-api/src/main_simple_ws.rs: use library modules instead of redeclaring; remove unused imports to satisfy clippy.
• scripts/ci_local.sh: mirror GH Actions rust steps for stability.

Validation

• Local: SQLX_OFFLINE=true cargo clippy --all-features passes.
• Local: SQLX_OFFLINE=true cargo clippy --no-default-features -D warnings passes.
• GitHub Actions: should remain green (Flutter analyze non-fatal).

Notes

• No behavior changes; endpoints and routes unchanged under default features.

[gemini-code-assist]

Summary of Changes

Hello @zensgit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the API's build process and CI/CD pipeline by introducing feature-gating for demo endpoints and aligning local development scripts with the GitHub Actions workflow. These changes ensure that placeholder API routes are only included when explicitly enabled, leading to a cleaner default build, and standardize the clippy linting process across development environments for improved code quality.

Highlights

• Feature Gating Demo Endpoints: Demo and placeholder API endpoints are now conditionally compiled using a demo_endpoints feature flag, preventing them from being included in default builds and ensuring a leaner application.
• Immutable Router Construction: The Axum router construction in main.rs has been refactored to be immutable, avoiding the need for a mut keyword when the demo_endpoints feature is disabled.
• CI Script Alignment: The local CI script (scripts/ci_local.sh) now mirrors GitHub Actions by first running cargo check --all-features and then cargo clippy --no-default-features -D warnings for stricter linting on the core application without demo endpoints.
• Refactored main_simple_ws.rs: jive-api/src/main_simple_ws.rs now correctly utilizes library modules from jive_money_api instead of redeclaring them, and unused imports have been removed to satisfy clippy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR implements feature-gating for demo/placeholder endpoints and aligns CI clippy modes. The main purpose is to improve code organization by conditionally compiling demo endpoints behind a feature flag while maintaining backward compatibility.

• Gate demo endpoints behind demo_endpoints feature flag with immutable router construction
• Align local and GitHub Actions CI scripts to use consistent clippy modes
• Clean up module imports and remove unused code to satisfy clippy

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
jive-api/Cargo.toml	Adds demo_endpoints feature configuration with default enabled
jive-api/src/main.rs	Refactors router to use feature-gated demo endpoint addition
jive-api/src/handlers/mod.rs	Feature-gates placeholder module import
jive-api/src/main_simple_ws.rs	Replaces local module declarations with library imports
scripts/ci_local.sh	Aligns clippy commands with GitHub Actions workflow
.github/workflows/ci.yml	Updates clippy to use --no-default-features mode

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Multiple routes are mapped to the same handler function. Lines 370 and 377 both route to export_data, lines 371 and 378 both route to activity_logs, etc. This creates ambiguous API endpoints that may confuse consumers about which endpoint to use.

Suggested change

	.route("/api/v1/export/data", post(export_data))
	.route("/api/v1/activity/logs", get(activity_logs))
	// 静态文件
	.route("/static/icons/*path", get(serve_icon))
	// 简化演示入口
	.route("/api/v1/export", get(export_data))
	.route("/api/v1/activity-logs", get(activity_logs))
	.route("/api/v1/advanced-settings", get(advanced_settings))
	.route("/api/v1/family-settings", get(family_settings));

[Copilot]

[nitpick] The cargo check output is being appended to the rust-tests.txt file, but this mixes build verification output with test results. Consider using a separate file like rust-build.txt for build verification output.

Suggested change

	cargo check --all-features | tee -a "$ART_DIR/rust-tests.txt"
	cargo check --all-features | tee "$ART_DIR/rust-build.txt"

[gemini-code-assist]

Code Review

This pull request effectively introduces a demo_endpoints feature flag to conditionally compile placeholder APIs, which is a great way to separate production code from demo code. The changes to the CI script to align local checks with GitHub Actions are also a solid improvement for consistency. My main feedback is a suggestion to refactor the router construction in main.rs to use a more idiomatic if cfg!(...) expression, which would improve readability and maintainability by consolidating the conditional logic into a single, clear block.