-
Notifications
You must be signed in to change notification settings - Fork 0
chore(dev): align dev compose ports + hooks target #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
65e3717
ci: surface docs-only fast path in summary and wire summary to change…
zensgit 6e89a1c
chore(dev): align docker-compose.dev ports with manager (5433/6380/90…
zensgit c427543
Merge remote-tracking branch 'origin/main' into chore/compose-port-al…
zensgit 894a3ae
chore: remove runtime file .pids/api.mode from VCS
zensgit 9159109
ci: short-circuit Flutter job when no Flutter changes; reduce flakine…
zensgit 37bc608
chore: ignore .pids/ runtime dir to avoid accidental commits
zensgit cf09a1a
ci: make field-compare resilient to missing Flutter artifacts; gate c…
zensgit 630b46e
ci: add full_run input; gate heavy jobs on manual dispatch; include e…
zensgit 5228eb8
fix(ci): skip Field Comparison Check when Flutter unchanged
zensgit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,7 @@ Cargo.lock | |
| # 日志文件 | ||
| *.log | ||
| logs/ | ||
| /.pids/ | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a
hookstarget that duplicates an existing one on lines 148-150. Having duplicate targets in a Makefile can lead to unpredictable behavior and makes the file harder to maintain.Please remove this duplicated block. You can enhance the existing target by adding
.PHONY: hooksabove it for correctness, like so: