docs: dev ports & hooks; ci: manual full_run gate #34
Conversation
zensgit
commented
Sep 24, 2025
zensgit
commented
- README: add local dev ports and make hooks\n- CI: add workflow_dispatch full_run input, gate heavy steps on manual runs, include event in concurrency key\n\nThis complements PR chore(dev): align dev compose ports + hooks target #33 (compose ports alignment, hooks target) with docs and CI polish.
…80); add Makefile hooks target
…ss while keeping required checks
…ompare on flutter_changed
…vent in concurrency key
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances local development setup and CI workflow efficiency. It aligns Docker port configurations between jive-api and jive-manager, adds documentation for local development ports and git hooks, and introduces manual workflow dispatch controls for heavy CI operations.
- Aligns Docker Compose ports with jive-manager defaults (PostgreSQL: 5433, Redis: 6380, Adminer: 9080)
- Adds documentation for local development ports and git hooks setup
- Introduces CI workflow dispatch controls to gate heavy operations on manual runs
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| jive-api/docker-compose.dev.yml | Updates port mappings to align with jive-manager defaults |
| README.md | Adds local development ports documentation and git hooks setup instructions |
| Makefile | Adds hooks target to enable git pre-commit hooks |
| .github/workflows/ci.yml | Adds manual workflow dispatch controls and optimizes Flutter job execution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| with: | ||
| name: test-report | ||
| path: . | ||
| if-no-files-found: ignore |
There was a problem hiding this comment.
The if-no-files-found: ignore parameter should be applied consistently. The Flutter analyzer output download step (lines 572-576) also needs this parameter to prevent failures when Flutter changes aren't detected.
| - name: No Flutter changes detected (short-circuit) | ||
| if: env.DOCS_ONLY != 'true' && env.FLUTTER_CHANGED != 'true' | ||
| run: | | ||
| echo "No Flutter changes; skipping analysis/tests to keep pipeline efficient." |
There was a problem hiding this comment.
This informational step runs but doesn't actually short-circuit the job. Consider using job-level conditions or restructuring the workflow to truly skip Flutter jobs when no changes are detected, rather than just logging a message.
1 participant
