-
Notifications
You must be signed in to change notification settings - Fork 0
flutter: const constructors cleanup (batch 3) #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unnecessary const keywords from widget constructors where the constructor parameters are not compile-time constants. The change focuses on cleaning up const usage in the QR code generator widget to ensure proper const correctness.
- Removed
constkeywords from Center and CircularProgressIndicator widgets that don't have const constructor parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @zensgit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues a series of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes const from widget constructors in qr_code_generator.dart. While the code remains valid, this change represents a minor performance pessimization. My review includes a suggestion to restore the const keyword, as this allows Flutter to optimize rendering by caching and reusing constant widgets, which is a recommended best practice.
| child: Center( | ||
| child: CircularProgressIndicator(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The const keyword was removed from Center and CircularProgressIndicator. Since both widgets are being constructed here without any non-constant parameters, they can and should be declared const. This allows Flutter to create a single, canonical instance of this widget subtree and reuse it, which improves performance.
| child: Center( | |
| child: CircularProgressIndicator(), | |
| child: const Center( | |
| child: const CircularProgressIndicator(), |
…Indicator (review feedback)
|
Addressed Gemini review: restored safe consts for Center/CircularProgressIndicator; kept non-const where runtime args (e.g., foregroundColor) are used to avoid invalid constants. Analyzer clean of hard errors; tests green. |
Safe const adjustments in QR generator (remove const where parameters are non-const). Analyzer/test green.