flutter: add User Assets overview + fix analyzer blockers; wire assets entrances (A/B/C) #64

zensgit · 2025-09-28T05:48:43Z

Purpose

Add a "用户资产总览" screen and wire three entrances (A/B/C) for quick navigation.
Resolve analyzer blockers to keep CI/tests green.

Summary of approach

New screen: jive-flutter/lib/screens/accounts/user_assets_screen.dart renders Net Worth, Total Assets/Liabilities KPIs and lists of asset/liability accounts (consumes account providers only; no behavior change to existing logic).
Router: add AppRoutes.userAssets and nested GoRoute under Accounts; import screen in router.
Entrances:
- A: Accounts AppBar pie icon; B: Accounts AppBar overflow menu item "资产总览".
- C: Dashboard AppBar pie icon as a top‑level quick entrance.
Analyzer fixes (surgical):
- AccountCard required args: switch callsites to AccountCard.fromAccount in account_list.dart.
- Remove invalid const where runtime style present in budget_progress.dart.
- Avoid use_of_void_result in family_settings_service.dart by splitting calls.
- Add Address stub for email service (mailer compatibility) in email_notification_service.dart.
- FamilyActivityLog: type _statistics as ActivityStatistics, add _parseActivityStatistics, use typed dialog.
- DashboardOverview: correct types (List, List, List) and adjust import.

Testing evidence

Ran locally:
- cd jive-flutter && flutter analyze → no hard errors (warnings remain by design).
- cd jive-flutter && flutter test -r compact → All tests passed (10/10).

Migration/notes

No DB/schema changes.
Navigation only; backward compatible. Dashboard/Accounts UI gains a single icon and one new menu item.

Rollback plan

Revert this PR or disable the new AppBar icon/menu entries; routes are additive and isolated.

…nce.share/shareXFiles in QR + ShareService; remove local stub

…hare_plus directly

…g and DeleteFamilyDialog

…or) + fix const-eval in common widgets

… adjustments

…pture and fix duplicates

…ignores; fix template onCancel and batch dialogs snackbars

…vigator capture and mounted guards

…rs (accounts/dashboard types, const-eval, family settings void, email Address stub); wire A/B/C entrances

Copilot

Pull Request Overview

This PR adds a "用户资产总览" (User Assets Overview) screen with three navigation entrances (A/B/C) and resolves Flutter analyzer blocking errors to maintain CI health.

Introduces a new user assets overview screen displaying net worth, total assets/liabilities KPIs, and categorized account lists
Wires three quick navigation entrances: Dashboard AppBar pie icon (C), Accounts AppBar pie icon (A), and Accounts overflow menu item (B)
Surgically fixes analyzer blockers including AccountCard constructor issues, const validation errors, void result usage, and missing Address class

Reviewed Changes

Copilot reviewed 46 out of 50 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
jive-flutter/lib/screens/accounts/user_assets_screen.dart	New screen implementing assets overview with net worth display and account categorization
jive-flutter/lib/core/router/app_router.dart	Adds userAssets route and nested GoRoute configuration
jive-flutter/lib/screens/dashboard/dashboard_screen.dart	Adds pie chart icon entrance (C) to Dashboard AppBar
jive-flutter/lib/screens/accounts/accounts_screen.dart	Adds pie chart icon entrance (A) and overflow menu item (B)
jive-flutter/lib/ui/components/accounts/account_list.dart	Fixes AccountCard constructor calls to use .fromAccount method
jive-flutter/lib/services/email_notification_service.dart	Adds Address stub class for mailer compatibility
jive-flutter/lib/services/family_settings_service.dart	Splits void-returning calls to avoid use_of_void_result
Multiple widget files	Removes invalid const keywords and fixes build context usage across async gaps

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-28T05:49:20Z

jive-flutter/lib/core/app.dart

+                          borderRadius: BorderRadius.all(Radius.circular(radius)),
                        ),
                      ),
                  inputDecorationTheme:
                      Theme.of(context).inputDecorationTheme.copyWith(
                            border: OutlineInputBorder(
-                              borderRadius: BorderRadius.circular(radius),
+                              borderRadius: BorderRadius.all(Radius.circular(radius)),
                            ),
                            focusedBorder: OutlineInputBorder(
-                              borderRadius: BorderRadius.circular(radius),
+                              borderRadius: BorderRadius.all(Radius.circular(radius)),


[nitpick] Using BorderRadius.circular(radius) is more concise and idiomatic than BorderRadius.all(Radius.circular(radius)).

Copilot · 2025-09-28T05:49:20Z

jive-flutter/lib/core/app.dart

+                          borderRadius: BorderRadius.all(Radius.circular(radius)),
                        ),
                      ),
                  inputDecorationTheme:
                      Theme.of(context).inputDecorationTheme.copyWith(
                            border: OutlineInputBorder(
-                              borderRadius: BorderRadius.circular(radius),
+                              borderRadius: BorderRadius.all(Radius.circular(radius)),
                            ),
                            focusedBorder: OutlineInputBorder(
-                              borderRadius: BorderRadius.circular(radius),
+                              borderRadius: BorderRadius.all(Radius.circular(radius)),


[nitpick] Using BorderRadius.circular(radius) is more concise and idiomatic than BorderRadius.all(Radius.circular(radius)).

gemini-code-assist · 2025-09-28T05:49:40Z

Summary of Changes

Hello @zensgit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new 'User Assets Overview' feature to the Flutter application, allowing users to quickly see their financial summary from multiple entry points. Concurrently, it undertakes a significant refactoring effort to resolve a large number of Flutter analyzer warnings and errors, ensuring a cleaner and more robust codebase. The changes also include minor improvements to the Rust backend with added tracing for authentication flows.

Highlights

New User Assets Overview Screen: Introduced a new 'User Assets Overview' screen in the Flutter application, providing a consolidated view of net worth, total assets, total liabilities, and lists of individual asset and liability accounts.
Multiple Navigation Entrances: Wired three distinct navigation points (A, B, C) to the new 'User Assets Overview' screen: an icon in the Accounts AppBar, a menu item in the Accounts AppBar overflow, and an icon in the Dashboard AppBar, enhancing accessibility.
Flutter Analyzer Fixes: Addressed numerous Flutter analyzer warnings and errors across various files, including use_build_context_synchronously, invalid_constant, use_of_void_result, and argument_type_not_assignable, significantly improving code quality and stability.
Rust Backend Tracing: Added detailed tracing logs to the Rust auth_service.rs for user registration and family creation processes, which will aid in debugging and monitoring backend operations.
Share Service Refactoring: Simplified the ShareService by removing screenshot-related functionality and external stub dependencies, unifying sharing to text-only methods to avoid analyzer issues and streamline the implementation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully adds the new 'User Assets Overview' screen and wires up the entry points as described. A significant portion of the changes also involves fixing a large number of analyzer errors and warnings, which is a great step towards improving code quality and stability. The fixes for use_build_context_synchronously, const correctness, and unused variables are well-executed.

I have a few suggestions to further improve the code, primarily focusing on using more idiomatic Rust for error handling and updating deprecated Flutter API usage in the new user_assets_screen.dart file to prevent future build failures. Overall, this is a solid contribution that adds a useful feature and enhances the codebase's health.

gemini-code-assist · 2025-09-28T05:51:36Z

jive-flutter/lib/screens/accounts/user_assets_screen.dart

+                Expanded(
+                  child: _buildKpi(theme, '总资产', stats.totalAssets, color: AppConstants.successColor),
+                ),
+                Container(width: 1, height: 24, color: theme.dividerColor.withValues(alpha: 0.5)),


The withValues method is an internal detail of the Color class and is being removed from the Flutter SDK. Using it can lead to build failures in future Flutter versions. Please use the public withOpacity method instead to set the color's transparency.

Suggested change

Container(width: 1, height: 24, color: theme.dividerColor.withValues(alpha: 0.5)),

Container(width: 1, height: 24, color: theme.dividerColor.withOpacity(0.5)),

gemini-code-assist · 2025-09-28T05:51:36Z

jive-flutter/lib/screens/accounts/user_assets_screen.dart

+      child: Column(
+        crossAxisAlignment: CrossAxisAlignment.start,
+        children: [
+          Text(label, style: theme.textTheme.bodySmall?.copyWith(color: theme.colorScheme.onSurface.withValues(alpha: 0.6))),


The withValues method is an internal API and is slated for removal. To ensure future compatibility, please use the recommended withOpacity method to adjust the color's alpha value.

Suggested change

Text(label, style: theme.textTheme.bodySmall?.copyWith(color: theme.colorScheme.onSurface.withValues(alpha: 0.6))),

Text(label, style: theme.textTheme.bodySmall?.copyWith(color: theme.colorScheme.onSurface.withOpacity(0.6))),

gemini-code-assist · 2025-09-28T05:51:36Z

jive-flutter/lib/screens/accounts/user_assets_screen.dart

+        .map((a) => ListTile(
+              contentPadding: const EdgeInsets.symmetric(horizontal: 0),
+              leading: CircleAvatar(
+                backgroundColor: (a.displayColor).withValues(alpha: 0.15),


To avoid using internal Flutter APIs that may be removed, please replace withValues with the public withOpacity method for setting the color's transparency.

Suggested change

backgroundColor: (a.displayColor).withValues(alpha: 0.15),

backgroundColor: a.displayColor.withOpacity(0.15),

gemini-code-assist · 2025-09-28T05:51:36Z

jive-api/src/services/auth_service.rs

+        let family = match family_service.create_family(user_id, family_request).await {
+            Ok(f) => f,
+            Err(e) => {
+                tracing::error!(target: "auth_service", error = ?e, user_id = %user_id, "register_with_family: create_family failed");
+                return Err(e);
+            }
+        };


While this match block correctly adds error logging, it's a bit verbose for propagating an error. You can make this more idiomatic and concise by using Result::map_err combined with the ? operator. This achieves the same goal of logging the error before it's propagated.

let family = family_service.create_family(user_id, family_request).await.map_err(|e| { tracing::error!(target: "auth_service", error = ?e, user_id = %user_id, "register_with_family: create_family failed"); e })?;

zensgit added 11 commits September 27, 2025 21:17

flutter: Share→SharePlus migration step 1 — switch to SharePlus.insta…

9d1eeae

…nce.share/shareXFiles in QR + ShareService; remove local stub

flutter: clean QR widget placeholder + remove local Share stub; use s…

6301183

…hare_plus directly

flutter: fix use_build_context_synchronously in AcceptInvitationDialo…

c1a00d2

…g and DeleteFamilyDialog

flutter: context cleanup batch 1 (right_click_copy, custom_theme_edit…

139d958

…or) + fix const-eval in common widgets

flutter: context safety fixes in ThemeShareDialog and DeleteFamilyDialog

cb8f290

flutter: context cleanup batch 2 (admin template page + batch op bar)

f187d07

flutter: fix AuditLogsScreen statistics type; continue context-safety…

741b89f

… adjustments

flutter: context cleanup batch 3 prep — refine messenger/navigator ca…

51c6be6

…pture and fix duplicates

flutter: context cleanup batch 3 — move captures post-await + scoped …

39c2f5f

…ignores; fix template onCancel and batch dialogs snackbars

flutter: context cleanup batch 3 — ThemeManagementScreen messenger/na…

a1e7950

…vigator capture and mounted guards

flutter: add User Assets overview screen + route; fix analyzer blocke…

d4124c3

…rs (accounts/dashboard types, const-eval, family settings void, email Address stub); wire A/B/C entrances

Copilot AI review requested due to automatic review settings September 28, 2025 05:48

zensgit enabled auto-merge (squash) September 28, 2025 05:49

Copilot AI reviewed Sep 28, 2025

View reviewed changes

gemini-code-assist bot reviewed Sep 28, 2025

View reviewed changes

Merge main into feature/user-assets-overview

117151c

zensgit merged commit 6c65ccc into main Oct 8, 2025
7 checks passed

zensgit deleted the feature/user-assets-overview branch October 8, 2025 02:58

zensgit mentioned this pull request Oct 15, 2025

core db track 1 #91

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

flutter: add User Assets overview + fix analyzer blockers; wire assets entrances (A/B/C) #64

flutter: add User Assets overview + fix analyzer blockers; wire assets entrances (A/B/C) #64

Uh oh!

zensgit commented Sep 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

gemini-code-assist bot commented Sep 28, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 28, 2025

Uh oh!

gemini-code-assist bot Sep 28, 2025

Uh oh!

gemini-code-assist bot Sep 28, 2025

Uh oh!

gemini-code-assist bot Sep 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	Container(width: 1, height: 24, color: theme.dividerColor.withValues(alpha: 0.5)),
	Container(width: 1, height: 24, color: theme.dividerColor.withOpacity(0.5)),

	Text(label, style: theme.textTheme.bodySmall?.copyWith(color: theme.colorScheme.onSurface.withValues(alpha: 0.6))),
	Text(label, style: theme.textTheme.bodySmall?.copyWith(color: theme.colorScheme.onSurface.withOpacity(0.6))),

	backgroundColor: (a.displayColor).withValues(alpha: 0.15),
	backgroundColor: a.displayColor.withOpacity(0.15),

flutter: add User Assets overview + fix analyzer blockers; wire assets entrances (A/B/C) #64

flutter: add User Assets overview + fix analyzer blockers; wire assets entrances (A/B/C) #64

Uh oh!

Conversation

zensgit commented Sep 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot commented Sep 28, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant