flutter: context cleanup batch 9 — QR share smoke test + dialog context fixes #78

zensgit · 2025-09-30T07:23:49Z

Add qr_share_smoke_test (platform-agnostic, uses ShareService._doShare)\n- DeleteFamilyDialog: pre-capture navigator/messenger + mounted guards (previously aligned)\n\nNotes: Remaining analyzer infos (prefer_const_constructors, conservative use_build_context_synchronously) will be handled in small follow-ups. Tests pass locally.

gemini-code-assist · 2025-09-30T07:24:00Z

Summary of Changes

Hello @zensgit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and test coverage of the Flutter application. It introduces a new smoke test to validate the QR code sharing mechanism and includes fixes for potential context-related issues within dialogs, ensuring more reliable UI behavior and preventing errors when widgets are unmounted.

Highlights

QR Share Smoke Test: A new platform-agnostic smoke test has been added for the ShareService.shareQrCode functionality, utilizing ShareService._doShare for testing purposes.
Dialog Context Fixes: Context-related issues in DeleteFamilyDialog have been addressed by pre-capturing navigator/messenger and adding mounted guards to prevent errors when widgets are unmounted.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot

Pull Request Overview

This PR enhances context safety and testing by adding a smoke test for QR sharing functionality and implementing proper context cleanup guards in dialogs. The changes focus on testing the ShareService QR code functionality and improving context handling in dialog operations.

Add platform-agnostic smoke test for ShareService QR sharing functionality
Implement pre-capture navigator/messenger pattern with mounted guards in DeleteFamilyDialog

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T07:24:12Z

jive-flutter/test/widgets/qr_share_smoke_test.dart

@@ -0,0 +1,37 @@
+


[nitpick] Remove the empty line at the beginning of the file to follow standard formatting conventions.

Suggested change

Copilot · 2025-09-30T07:24:13Z

jive-flutter/test/widgets/qr_share_smoke_test.dart

+    });
+
+    await tester.pumpWidget(
+      const MaterialApp(home: SizedBox.shrink()),


[nitpick] Consider using Scaffold() instead of SizedBox.shrink() as the home widget. This provides a more realistic widget tree for testing context-dependent operations.

Suggested change

const MaterialApp(home: SizedBox.shrink()),

const MaterialApp(home: Scaffold()),

gemini-code-assist

Code Review

This pull request adds a smoke test for the QR code sharing functionality. The new test is well-structured. I've suggested an improvement to make the test suite more comprehensive by adding a test case for when the optional description is not provided and by grouping related tests for better organization. This will help ensure the formatting is correct in all scenarios and improve the overall test quality.

gemini-code-assist · 2025-09-30T07:25:36Z

jive-flutter/test/widgets/qr_share_smoke_test.dart

+  testWidgets('ShareService.shareQrCode shares expected text', (tester) async {
+    ShareParams? last;
+    ShareService.setDoShareForTest((params) async {
+      last = params;
+      return const ShareResult('', ShareResultStatus.success);
+    });
+
+    await tester.pumpWidget(
+      const MaterialApp(home: SizedBox.shrink()),
+    );
+
+    final ctx = tester.element(find.byType(SizedBox));
+
+    await ShareService.shareQrCode(
+      context: ctx,
+      data: 'https://example.com/q/XYZ',
+      title: '示例二维码',
+      description: '用于测试的二维码',
+    );
+
+    expect(last, isNotNull);
+    final text = last!.text ?? '';
+    expect(text, contains('示例二维码'));
+    expect(text, contains('用于测试的二维码'));
+    expect(text, contains('https://example.com/q/XYZ'));
+  });


To improve test organization and coverage, it's a good practice to group related tests using group(). Additionally, since ShareService.shareQrCode has an optional description parameter, adding a test case for when it's null would make the test suite more robust. This ensures that the text formatting is correct in both scenarios.

There might be a subtle formatting issue in the implementation when description is null (potentially an extra newline). A dedicated test case will help catch and verify this.

group('ShareService.shareQrCode', () { testWidgets('shares expected text with description', (tester) async { ShareParams? last; ShareService.setDoShareForTest((params) async { last = params; return const ShareResult('', ShareResultStatus.success); }); await tester.pumpWidget( const MaterialApp(home: SizedBox.shrink()), ); final ctx = tester.element(find.byType(SizedBox)); await ShareService.shareQrCode( context: ctx, data: 'https://example.com/q/XYZ', title: '示例二维码', description: '用于测试的二维码', ); expect(last, isNotNull); final text = last!.text ?? ''; expect(text, contains('示例二维码')); expect(text, contains('用于测试的二维码')); expect(text, contains('https://example.com/q/XYZ')); }); testWidgets('shares expected text without description', (tester) async { ShareParams? last; ShareService.setDoShareForTest((params) async { last = params; return const ShareResult('', ShareResultStatus.success); }); await tester.pumpWidget( const MaterialApp(home: SizedBox.shrink()), ); final ctx = tester.element(find.byType(SizedBox)); await ShareService.shareQrCode( context: ctx, data: 'https://example.com/q/XYZ', title: '示例二维码', ); expect(last, isNotNull); final text = last!.text ?? ''; expect(text, contains('示例二维码')); expect(text, isNot(contains('用于测试的二维码'))); expect(text, contains('https://example.com/q/XYZ')); }); });

…alog, refreshable_list, currency_converter

test: add QR share smoke test using ShareService _doShare hook

266ce33

Copilot AI review requested due to automatic review settings September 30, 2025 07:23

zensgit enabled auto-merge (squash) September 30, 2025 07:23

Copilot AI reviewed Sep 30, 2025

View reviewed changes

gemini-code-assist bot reviewed Sep 30, 2025

View reviewed changes

chore: remove unused imports; fix const-eval hints in color_picker_di…

4095379

…alog, refreshable_list, currency_converter

zensgit merged commit 3228c47 into main Sep 30, 2025
9 checks passed

zensgit deleted the flutter/context-cleanup-batch9 branch September 30, 2025 08:17

zensgit mentioned this pull request Oct 15, 2025

core db track 1 #91

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

flutter: context cleanup batch 9 — QR share smoke test + dialog context fixes #78

flutter: context cleanup batch 9 — QR share smoke test + dialog context fixes #78

Uh oh!

zensgit commented Sep 30, 2025

Uh oh!

gemini-code-assist bot commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	const MaterialApp(home: SizedBox.shrink()),
	const MaterialApp(home: Scaffold()),

flutter: context cleanup batch 9 — QR share smoke test + dialog context fixes #78

flutter: context cleanup batch 9 — QR share smoke test + dialog context fixes #78

Uh oh!

Conversation

zensgit commented Sep 30, 2025

Uh oh!

gemini-code-assist bot commented Sep 30, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant