Skip to content

flutter: QR widget cleanup + SharePlus usage in invite dialog #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

flutter: QR widget cleanup + SharePlus usage in invite dialog #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d01698
flutter: cleanup QR widget stubs, fix const eval, use SharePlus.insta…
zensgit Sep 30, 2025
c1a3be5
flutter: tidy qr_code_generator structure; remove cross_file import a…
zensgit Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 3 additions & 38 deletions jive-flutter/lib/widgets/qr_code_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class _QrCodeGeneratorState extends State<QrCodeGenerator>
width: widget.size,
height: widget.size,
child: const Center(
child: const CircularProgressIndicator(),
child: CircularProgressIndicator(),
),
)
: ScaleTransition(
Expand Down Expand Up @@ -299,35 +299,6 @@ class _QrCodeGeneratorState extends State<QrCodeGenerator>
],
);
}

// Stub methods for missing external dependencies
dynamic XFile(String path) {
return _StubXFile(path);
}

Widget QrImageView({
required String data,
dynamic version,
double? size,
Color? backgroundColor,
Color? foregroundColor,
dynamic errorCorrectionLevel,
dynamic embeddedImage,
double? embeddedImageSizeRatio,
EdgeInsets? padding,
}) {
return Container(
width: size ?? 200,
height: size ?? 200,
color: backgroundColor ?? Colors.white,
child: Center(
child: Text(
'QR Code Placeholder',
style: TextStyle(color: foregroundColor ?? Colors.black),
),
),
);
}
}

/// 操作按钮
Expand Down Expand Up @@ -479,12 +450,12 @@ class InvitationQrCodeDialog extends StatelessWidget {
icon: const Icon(Icons.share),
label: const Text('分享'),
onPressed: () async {
await Share.share(
await SharePlus.instance.share(ShareParams(text:
'邀请你加入家庭「$familyName」\n\n'
Comment on lines +453 to 454
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ShareParams constructor call spans multiple lines but is missing proper parameter naming. Consider using named parameter 'text:' explicitly and proper formatting for better readability.

Suggested change
await SharePlus.instance.share(ShareParams(text:
'邀请你加入家庭「$familyName」\n\n'
await SharePlus.instance.share(ShareParams(
text: '邀请你加入家庭「$familyName」\n\n'

Copilot uses AI. Check for mistakes.
'邀请码：$inviteCode\n'
'点击链接加入：$inviteLink\n\n'
'有效期：$daysLeft 天',
);
));
},
Comment on lines 452 to 459
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's a good practice to extract the multi-line string into a separate variable before passing it to the share method. This makes the code cleaner and easier to understand.

                    onPressed: () async {
                      final shareText = '邀请你加入家庭「$familyName」\n\n'
                          '邀请码：$inviteCode\n'
                          '点击链接加入：$inviteLink\n\n'
                          '有效期：$daysLeft 天';
                      await SharePlus.instance.share(ShareParams(text: shareText));
                    },

),
),
Expand Down Expand Up @@ -540,9 +511,3 @@ class _InfoRow extends StatelessWidget {
}
}


// Stub implementation for XFile
class _StubXFile {
final String path;
_StubXFile(this.path);
}