flutter: ShareService — unify SharePlus usage + micro-cleanups #83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,10 @@ import 'package:flutter/material.dart'; | |
| import 'package:jive_money/core/constants/app_constants.dart'; | ||
| import 'package:jive_money/ui/components/cards/account_card.dart'; | ||
| import 'package:jive_money/ui/components/loading/loading_widget.dart'; | ||
| import 'package:jive_money/models/account.dart' as model; | ||
|
|
||
| // 类型别名以兼容现有代码 | ||
| typedef AccountData = model.Account; | ||
|
|
||
| class AccountList extends StatelessWidget { | ||
| final List<AccountData> accounts; | ||
|
|
@@ -102,7 +102,7 @@ class AccountList extends StatelessWidget { | |
| itemCount: accounts.length, | ||
| itemBuilder: (context, index) { | ||
| final account = accounts[index]; | ||
| return AccountCard.fromAccount( | ||
| account: account, | ||
| onTap: () => onAccountTap?.call(account), | ||
| onLongPress: () => onAccountLongPress?.call(account), | ||
|
|
@@ -138,7 +138,7 @@ class AccountList extends StatelessWidget { | |
|
|
||
| // 该类型的账户 | ||
| ...typeAccounts.map( | ||
| (account) => AccountCard.fromAccount( | ||
| account: account, | ||
| onTap: () => onAccountTap?.call(account), | ||
| onLongPress: () => onAccountLongPress?.call(account), | ||
|
|
@@ -284,10 +284,11 @@ class AccountList extends StatelessWidget { | |
| final Map<AccountType, List<AccountData>> grouped = {}; | ||
|
|
||
| for (final account in accounts) { | ||
| final key = _toUiAccountType(account.type); | ||
| if (!grouped.containsKey(key)) { | ||
| grouped[key] = []; | ||
| } | ||
| grouped[key]!.add(account); | ||
| } | ||
|
|
||
| // 按类型排序：资产、负债 | ||
|
|
@@ -299,7 +300,7 @@ class AccountList extends StatelessWidget { | |
|
|
||
| double _calculateTotal(AccountType type) { | ||
| return accounts | ||
| .where((account) => _matchesLocalType(type, account.type)) | ||
| .fold(0.0, (sum, account) => sum + account.balance); | ||
| } | ||
|
|
||
|
|
@@ -360,6 +361,26 @@ enum AccountSubType { | |
| mortgage, // 房贷 | ||
| } | ||
|
|
||
|
|
||
| // Model<->UI AccountType adapter | ||
| // Map model.AccountType (checking/savings/creditCard/loan/...) to local grouping (asset/liability) | ||
| AccountType _toUiAccountType(model.AccountType t) { | ||
|
Comment on lines
+364
to
+367
There was a problem hiding this comment. The helper functions |
||
| switch (t) { | ||
| case model.AccountType.creditCard: | ||
| case model.AccountType.loan: | ||
| return AccountType.liability; | ||
| default: | ||
| return AccountType.asset; | ||
| } | ||
| } | ||
|
|
||
| bool _matchesLocalType(AccountType localType, model.AccountType modelType) { | ||
| final isLiability = modelType == model.AccountType.creditCard || modelType == model.AccountType.loan; | ||
| if (localType == AccountType.liability) return isLiability; | ||
| return !isLiability; | ||
| } | ||
|
Comment on lines
+377
to
+381
There was a problem hiding this comment. The implementation of bool _matchesLocalType(AccountType localType, model.AccountType modelType) {
return _toUiAccountType(modelType) == localType;
} |
||
|
|
||
|
|
||
| /// 账户分组列表 | ||
| class GroupedAccountList extends StatelessWidget { | ||
| final Map<String, List<AccountData>> groupedAccounts; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The null-aware operator on
urlsuggests it might be null, but this could result in the text ending with an empty string. Consider handling null urls more explicitly, such as only appending the url if it's not null.