flutter: analyzer cleanup batch 10-E — small safe fixes

[zensgit]

Summary

• Const-eval polish in color_picker_dialog (const SizedBox, const OutlineInputBorder)
• LoadingIndicator spacing const
• RightClickCopy: precise one-line ignore at showMenu (pre-captured messenger)
• FamilySettingsService: mark unused key; fix void usage in _syncToServer
• DeepLinkService: null-safe linkStream handling
• EmailNotificationService: use local _Address stub; keep Message/_StubMessage/send stubs

Validation

• flutter analyze: 251 issues (down from 263), no new errors from this batch
• flutter test: 14/14 passing

Notes

• Behavior unchanged; scoped to analyzer cleanup.
• Follow-ups: tighten batch_operation_bar context ignores; optional more const polish.

[Copilot]

Pull Request Overview

This PR focuses on analyzer cleanup by fixing various static analysis warnings without changing application behavior. The changes primarily involve const optimizations, precise analyzer ignores, and null-safety improvements.

• Adds const keywords to improve compile-time evaluation and reduce runtime allocations
• Fixes analyzer warnings about unused variables and improper void usage
• Improves null-safety handling in link stream processing

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
jive-flutter/lib/widgets/states/loading_indicator.dart	Added const to SizedBox widget
jive-flutter/lib/widgets/common/right_click_copy.dart	Added precise analyzer ignore comment for async context usage
jive-flutter/lib/widgets/color_picker_dialog.dart	Added const keywords to multiple widgets for compile-time evaluation
jive-flutter/lib/services/family_settings_service.dart	Marked unused variable and fixed void return value handling
jive-flutter/lib/services/email_notification_service.dart	Changed Address to _Address for local stub usage
jive-flutter/lib/services/deep_link_service.dart	Added null-safety handling for link stream

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Summary of Changes

Hello @zensgit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a batch of small, safe fixes aimed at improving code quality and reducing analyzer warnings across various services and widgets. The changes primarily involve applying const modifiers for compile-time constant evaluation, enhancing null-safety, resolving unused variable warnings, and correcting minor logical flows, all without altering the existing behavior of the application. This cleanup contributes to a healthier codebase and fewer analyzer issues.

Highlights

• Const-evaluation improvements: Applied const keyword to SizedBox, OutlineInputBorder, and Text widgets in color_picker_dialog.dart and loading_indicator.dart for better performance and adherence to Flutter best practices.
• Null-safety enhancements: Implemented a null-safe check for uni_links.linkStream in DeepLinkService to prevent processing empty or null deep links.
• Analyzer warning resolution: Addressed an unused variable warning in FamilySettingsService by commenting out _keySyncStatus and added a precise ignore comment for use_build_context_synchronously in RightClickCopy.
• Code logic correction: Fixed the _syncToServer method in FamilySettingsService to correctly assign success = true after asynchronous operations, resolving a potential void usage issue.
• Internal API usage: Switched to using a local _Address stub in EmailNotificationService for the from field in email messages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several small, safe fixes and cleanups across various files, primarily to address analyzer warnings. The changes include adding const to improve performance, fixing null safety issues, and removing unused code. My review focuses on the correctness and maintainability of these changes. I've found one critical issue where a required stub class is missing, which will break compilation. I've also provided a suggestion to simplify the logic in another file for better readability.

[gemini-code-assist]

The class _Address is not defined in this file, which will cause a compilation error. Based on the PR description, it seems a local stub was intended. Please add the _Address stub class to this file.

For example, you could add a stub similar to this:

class _Address {
  final String address;
  final String? name;
  const _Address(this.address, [this.name]);
}

[gemini-code-assist]

This logic for handling a nullable link can be simplified. The _handleDeepLink function and its subsequent call to _parseDeepLink can gracefully handle an empty string, so checking for isEmpty is redundant. A simple null check is cleaner and sufficient.

Suggested change

	final v = link ?? '';
	if (v.isEmpty) return;
	_handleDeepLink(v);
	if (link != null) _handleDeepLink(link);