-
Notifications
You must be signed in to change notification settings - Fork 0
tests: add Decimal serialization contract tests #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zensgit
merged 2 commits into
chore/invitations-audit-align-dev-mock
from
chore/decimal-contract-tests
Oct 15, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| use chrono::{TimeZone, Utc}; | ||
| use rust_decimal::Decimal; | ||
| use serde_json::Value; | ||
|
|
||
| #[test] | ||
| fn global_market_stats_decimal_serializes_as_string() { | ||
| use jive_money_api::models::global_market::GlobalMarketStats; | ||
|
|
||
| let stats = GlobalMarketStats { | ||
| total_market_cap_usd: Decimal::new(12_345_000_000, 0), | ||
| total_volume_24h_usd: Decimal::new(987_654_321, 0), | ||
| btc_dominance_percentage: Decimal::new(485, 1), // 48.5 | ||
| eth_dominance_percentage: Some(Decimal::new(180, 1)), // 18.0 | ||
| active_cryptocurrencies: 1000, | ||
| markets: Some(500), | ||
| updated_at: 1_700_000_000, | ||
| }; | ||
|
|
||
| let val: Value = serde_json::to_value(&stats).expect("serialize market stats"); | ||
| for key in [ | ||
| "total_market_cap_usd", | ||
| "total_volume_24h_usd", | ||
| "btc_dominance_percentage", | ||
| ] { | ||
| assert!(val.get(key).and_then(|v| v.as_str()).is_some(), "{} should be string", key); | ||
| } | ||
| // updated_at is numeric unix timestamp | ||
| assert!(val.get("updated_at").and_then(|v| v.as_i64()).is_some()); | ||
| assert!(val | ||
| .get("eth_dominance_percentage") | ||
| .and_then(|v| v.as_str()) | ||
| .is_some()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn account_response_decimal_serializes_as_string() { | ||
| use jive_money_api::handlers::accounts::AccountResponse; | ||
| use uuid::Uuid; | ||
|
|
||
| let resp = AccountResponse { | ||
| id: Uuid::nil(), | ||
| ledger_id: Uuid::nil(), | ||
| bank_id: None, | ||
| name: "Checking".to_string(), | ||
| account_type: "asset".to_string(), | ||
| account_number: None, | ||
| institution_name: None, | ||
| currency: "USD".to_string(), | ||
| current_balance: Decimal::new(12345, 2), | ||
| available_balance: Some(Decimal::new(12000, 2)), | ||
| credit_limit: None, | ||
| status: "active".to_string(), | ||
| is_manual: true, | ||
| color: None, | ||
| icon: None, | ||
| notes: None, | ||
| created_at: Utc.timestamp_opt(1_700_000_000, 0).unwrap(), | ||
| updated_at: Utc.timestamp_opt(1_700_000_000, 0).unwrap(), | ||
| }; | ||
|
|
||
| let val: Value = serde_json::to_value(&resp).expect("serialize account response"); | ||
| for key in ["current_balance"] { | ||
| assert!(val.get(key).and_then(|v| v.as_str()).is_some(), "{} should be string", key); | ||
| } | ||
| // Optional Decimal fields should also be strings when present | ||
| assert!(val | ||
| .get("available_balance") | ||
| .and_then(|v| v.as_str()) | ||
| .is_some()); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test function is named
global_market_stats_decimal_serializes_as_string, which implies its scope is limited to testingDecimalfields. The added assertion forupdated_at(ani64) is outside this scope. While testing the entire contract is important, mixing concerns within a single test can make the test suite harder to understand and maintain. It's best practice for a test to have a single, clear purpose reflected in its name.To improve clarity, I recommend moving this check to a separate test function, for example
global_market_stats_numeric_fields_are_serialized_correctly. This would keep your tests focused and self-documenting.