-
-
Notifications
You must be signed in to change notification settings - Fork 38
docs: release 2.10.0 #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: release 2.10.0 #399
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request updates the documentation for the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/reference/plugins/tanstack-query.mdx (1)
691-705: Consider adding error handling example for query cancellationWhile the new section on query cancellation is well-documented, it would be beneficial to show how to handle potential errors during cancellation.
Consider adding an example like this:
function onCancel() { - queryClient.cancelQueries({ queryKey, exact: true }); + try { + queryClient.cancelQueries({ queryKey, exact: true }); + } catch (error) { + console.error('Failed to cancel query:', error); + } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
docs/reference/plugins/tanstack-query.mdx(3 hunks)
🔇 Additional comments (3)
docs/reference/plugins/tanstack-query.mdx (3)
55-58: LGTM: Clear explanation of query hook return values
The documentation clearly explains that query hooks return a standard TanStack Query result with an additional queryKey field, and properly documents the data field content.
70-70: LGTM: Clear explanation of mutation hook return values
The documentation accurately describes the mutation hook return value and provides a good example of the mutation argument format.
685-689: LGTM: Good addition of queryKey field documentation
The documentation properly explains that query hooks return the queryKey in the result object and provides a clear example of destructuring it.
Summary by CodeRabbit
@zenstackhq/tanstack-queryplugin to clarify the functionality of generated hooks.