-
-
Notifications
You must be signed in to change notification settings - Fork 38
doc: add package migration to v2-migration doc #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a new React component Changes
Sequence Diagram(s)sequenceDiagram
participant Doc as Migration Doc (migrate-v2.md)
participant Comp as PackageUninstall
participant UI as Tabbed UI
participant CB as CodeBlock
Note over Doc,Comp: Doc imports and renders the component
Doc->>Comp: <PackageUninstall dependencies=[...]/>
activate Comp
Comp->>UI: create tabs [npm,pnpm,bun,yarn]
UI->>CB: render command for active tab
CB-->>UI: display uninstall command string
UI-->>Comp: tab switch (user)
deactivate Comp
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
versioned_docs/version-3.x/_components/PackageUninstall.tsx (1)
22-22: Remove unnecessary optional chaining.The optional chaining
dependencies?.lengthis unnecessary sincedependenciesis a required prop in thePropsinterface (line 6).Apply this diff:
- {`${dependencies?.length ? `${pkg.command} ${dependencies.join(' ')}` : ''}`} + {dependencies.length ? `${pkg.command} ${dependencies.join(' ')}` : ''}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
versioned_docs/version-3.x/_components/PackageUninstall.tsx(1 hunks)versioned_docs/version-3.x/migrate-v2.md(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
versioned_docs/version-3.x/_components/PackageUninstall.tsx (1)
versioned_docs/version-3.x/_components/PackageInstall.tsx (1)
Props(17-31)
🔇 Additional comments (3)
versioned_docs/version-3.x/_components/PackageUninstall.tsx (1)
1-7: LGTM!The imports and Props interface are correctly defined.
versioned_docs/version-3.x/migrate-v2.md (2)
7-7: LGTM!The import statement is correctly structured.
44-55: LGTM!The new "Migrating ZenStack Packages" section is well-structured and clearly documents the package renames. The interactive examples using both
PackageUninstallandPackageInstallcomponents provide a good user experience for the migration process.
Summary by CodeRabbit
New Features
Documentation