Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Jun 2, 2025

Summary by CodeRabbit

  • New Features
    • Added support for specifying distinct fields in find queries, allowing users to retrieve unique records based on one or more fields.
  • Bug Fixes
    • None.
  • Tests
    • Added tests to verify correct behavior when using the distinct option in find queries.
  • Documentation
    • Updated checklist to reflect completion of the distinct feature in the ORM section.

@coderabbitai
Copy link

coderabbitai bot commented Jun 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Support for the distinct argument in find queries was added to the ORM. This includes type-level, schema, and runtime handling, dialect capability detection, and in-memory fallback for dialects lacking native support. Tests were added to verify the new feature. Some method visibilities were also updated for encapsulation.

Changes

File(s) Change Summary
TODO.md Updated checklist: marked "Distinct" as complete and "Prisma client extension" as incomplete.
.../crud-types.ts, .../schema.ts Added Distinct type, updated FindArgs to support distinct, refined GetFields type alias.
.../crud/dialects/base.ts, .../dialects/postgresql.ts, .../dialects/sqlite.ts Made supportsUpdateWithLimit abstract; added abstract supportsDistinctOn getter, implemented in dialects.
.../crud/operations/base.ts Added handling for the distinct argument in the read method, with dialect support and in-memory fallback.
.../crud/validator.ts Added distinct field to query validation; made several schema methods private; added private makeDistinctSchema.
.../query-utils.ts Added ensureArray utility function.
.../crud/operations/create.ts Type assertion update for getIdValues result.
.../test/client-api/find.test.ts Added tests for findMany with distinct on single and multiple fields.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ORM
    participant Dialect
    participant DB

    Client->>ORM: findMany({ distinct: ... })
    ORM->>Dialect: Check supportsDistinctOn
    alt Dialect supports DISTINCT ON
        ORM->>DB: Query with DISTINCT ON fields
        DB-->>ORM: Results
    else Dialect does not support DISTINCT ON
        ORM->>DB: Query without DISTINCT
        DB-->>ORM: Results
        ORM->>ORM: In-memory distinct filtering
    end
    ORM-->>Client: Distinct results
Loading

Poem

In fields of data, rabbits leap,
Distinct and nimble, never sheep.
Now queries hop, unique and bright,
Through dialects, day and night.
With tests and types, we bound ahead,
Distinctly clever—enough said!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ecbe4c and 934ff69.

📒 Files selected for processing (11)
  • TODO.md (2 hunks)
  • packages/runtime/src/client/crud-types.ts (2 hunks)
  • packages/runtime/src/client/crud/dialects/base.ts (1 hunks)
  • packages/runtime/src/client/crud/dialects/postgresql.ts (1 hunks)
  • packages/runtime/src/client/crud/dialects/sqlite.ts (1 hunks)
  • packages/runtime/src/client/crud/operations/base.ts (3 hunks)
  • packages/runtime/src/client/crud/operations/create.ts (1 hunks)
  • packages/runtime/src/client/crud/validator.ts (8 hunks)
  • packages/runtime/src/client/query-utils.ts (1 hunks)
  • packages/runtime/src/schema/schema.ts (1 hunks)
  • packages/runtime/test/client-api/find.test.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ymc9 ymc9 merged commit 0e36134 into dev Jun 2, 2025
1 check passed
@ymc9 ymc9 deleted the feat/distinct branch November 25, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants