chore: reorg test schemas

[ymc9]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/restructure-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[claude]

Claude finished @ymc9's task —— View job

---

PR Review: Test Schema Reorganization

Review Tasks:

• Analyze the overall file reorganization structure
• Review import path changes for correctness
• Check new generated files in todo schema
• Evaluate organizational benefits and potential issues
• Provide comprehensive feedback

---

✅ Summary

This is a well-executed organizational refactoring that improves the test structure significantly. The changes are primarily mechanical file moves and import path updates with no functional logic changes.

🎯 Positive Aspects

1. Improved Organization

• Clear separation of test schemas into logical directories (basic/, todo/, typing/)
• Each schema now has its own self-contained directory with all related files
• Better discoverability and maintainability of test schemas

2. Consistent Structure

• Each schema directory follows the same pattern: schema.zmodel, schema.ts, models.ts, input.ts, helper.ts/index.ts
• Generated files are properly organized alongside their source schemas

3. Correct Implementation

• All import paths consistently updated from ../test-schemas/xxx to ../schemas/xxx
• Generation script properly updated to use glob pattern ../schemas/**/*.zmodel
• No breaking changes to test functionality

🔍 Code Quality Assessment

Import Path Changes: ✅ Excellent

• All 44 files consistently updated with correct relative paths
• No missing or incorrect import updates found

Generated Files: ✅ Proper

• New generated TypeScript files follow established patterns
• Proper header warnings indicating they're auto-generated
• Correct import paths in generated files

Schema Generation: ✅ Well-structured

• packages/runtime/test/scripts/generate.ts:11 properly updated to use glob pattern
• Maintains existing functionality while supporting new structure

🚨 Potential Issues Found

Minor Issues:

1. SDK Generator Changes (packages/sdk/src/ts-schema-generator.ts): The changes appear to be related to this reorganization but should be verified to ensure they don't impact production schema generation.

2. Test Coverage: While the reorganization is good, the todo schema appears to be the most comprehensive with policy tests. Consider ensuring all schemas have adequate test coverage.

🔒 Security & Performance

Security: ✅ No concerns

• Only organizational changes, no security implications
• Generated files contain expected schema definitions

Performance: ✅ No impact

• File organization changes don't affect runtime performance
• Generation script efficiency maintained

📋 Test Coverage

Coverage Assessment: ✅ Maintained

• All existing tests preserved with updated import paths
• No test functionality removed or modified
• Test execution should be unaffected

💡 Recommendations

1. Consider Documentation: Update any documentation that references the old test schema paths (though none were found in this PR)

2. IDE Experience: The new organization will improve IDE navigation and code exploration

3. Future Schemas: This structure provides a good template for adding new test schemas

🎯 Final Assessment

Overall Rating: ⭐⭐⭐⭐⭐ Excellent

This is a textbook example of a good organizational refactoring:

• ✅ Clear improvement to codebase structure
• ✅ Consistent implementation across all files
• ✅ No functional changes or breaking changes
• ✅ Maintains all existing functionality
• ✅ Sets up better foundation for future development

Recommendation: Approve - This PR significantly improves the test structure without any functional risks.

---

[Copilot]

Pull Request Overview

This PR reorganizes the test schema structure by moving schema files into a centralized schemas directory and updates all corresponding import paths.

• Consolidates test schemas under a schemas directory structure
• Updates TypeScript schema generation script to process all schema files in the directory
• Improves type safety by adding proper return types for test client functions

Reviewed Changes

Copilot reviewed 35 out of 44 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/sdk/src/ts-schema-generator.ts	Enhanced schema import generation to conditionally include schema object for enums
packages/runtime/test/utils.ts	Added proper TypeScript return type for createTestClient function
packages/runtime/test/scripts/generate.ts	Modified to process all zmodel files in schemas directory with updated import paths
packages/runtime/test/schemas/typing/verify-typing.ts	Updated import path to use new directory structure
packages/runtime/test/schemas/typing/schema.ts	Updated import path to use new directory structure
packages/runtime/test/schemas/todo/*	Added new generated schema files for todo model
packages/runtime/test/schemas/basic/schema.ts	Updated import path to use new directory structure
packages/runtime/test/policy/*	Updated import paths and improved type safety
packages/runtime/test/plugin/*	Updated import paths to use new schema location
packages/runtime/test/client-api/*	Updated all import paths to use new schema location
packages/runtime/package.json	Modified build script to include test generation

Comments suppressed due to low confidence (2)

packages/runtime/test/policy/todo-sample.test.ts:377

• The optional chaining operator suggests that r could be null/undefined, but the test doesn't verify this condition. Consider adding a null check assertion before testing the array length to ensure the test fails meaningfully if the query returns null.

        expect(r?.lists).toHaveLength(2);

packages/runtime/test/policy/todo-sample.test.ts:383

• Similar to the previous assertion, the optional chaining suggests r1 could be null/undefined. Consider adding a null check assertion before testing the array length to make the test more robust.

        expect(r1?.lists).toHaveLength(1);