chore: addressing PR comments

.github/workflows/claude-code-review.yml

@@ -1,78 +1,77 @@
 name: Claude Code Review
 
 on:
-  pull_request:
-    types: [opened, synchronize]
-    # Optional: Only run on specific file changes
-    # paths:
-    #   - "src/**/*.ts"
-    #   - "src/**/*.tsx"
-    #   - "src/**/*.js"
-    #   - "src/**/*.jsx"
+    pull_request:
+        types: [opened, synchronize]
+        # Optional: Only run on specific file changes
+        # paths:
+        #   - "src/**/*.ts"
+        #   - "src/**/*.tsx"
+        #   - "src/**/*.js"
+        #   - "src/**/*.jsx"
 
 jobs:
-  claude-review:
-    # Optional: Filter by PR author
-    # if: |
-    #   github.event.pull_request.user.login == 'external-contributor' ||
-    #   github.event.pull_request.user.login == 'new-developer' ||
-    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
-
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      pull-requests: read
-      issues: read
-      id-token: write
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 1
+    claude-review:
+        # Optional: Filter by PR author
+        # if: |
+        #   github.event.pull_request.user.login == 'external-contributor' ||
+        #   github.event.pull_request.user.login == 'new-developer' ||
+        #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
 
-      - name: Run Claude Code Review
-        id: claude-review
-        uses: anthropics/claude-code-action@beta
-        with:
-          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+        runs-on: ubuntu-latest
+        permissions:
+            contents: read
+            pull-requests: write
+            issues: read
+            id-token: write
 
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
-          # model: "claude-opus-4-20250514"
-
-          # Direct prompt for automated review (no @claude mention needed)
-          direct_prompt: |
-            Please review this pull request and provide feedback on:
-            - Code quality and best practices
-            - Potential bugs or issues
-            - Performance considerations
-            - Security concerns
-            - Test coverage
-            
-            Be constructive and helpful in your feedback.
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+              with:
+                  fetch-depth: 1
 
-          # Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
-          # use_sticky_comment: true
-
-          # Optional: Customize review based on file types
-          # direct_prompt: |
-          #   Review this PR focusing on:
-          #   - For TypeScript files: Type safety and proper interface usage
-          #   - For API endpoints: Security, input validation, and error handling
-          #   - For React components: Performance, accessibility, and best practices
-          #   - For tests: Coverage, edge cases, and test quality
-
-          # Optional: Different prompts for different authors
-          # direct_prompt: |
-          #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' && 
-          #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
-          #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
-
-          # Optional: Add specific tools for running tests or linting
-          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
-
-          # Optional: Skip review for certain conditions
-          # if: |
-          #   !contains(github.event.pull_request.title, '[skip-review]') &&
-          #   !contains(github.event.pull_request.title, '[WIP]')
+            - name: Run Claude Code Review
+              id: claude-review
+              uses: anthropics/claude-code-action@beta
+              with:
+                  claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
+                  # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
+                  # model: "claude-opus-4-20250514"
+
+                  # Direct prompt for automated review (no @claude mention needed)
+                  direct_prompt: |
+                      Please review this pull request and provide feedback on:
+                      - Code quality and best practices
+                      - Potential bugs or issues
+                      - Performance considerations
+                      - Security concerns
+                      - Test coverage
+
+                      Be constructive and helpful in your feedback.
+
+                  # Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
+                  # use_sticky_comment: true
+
+                  # Optional: Customize review based on file types
+                  # direct_prompt: |
+                  #   Review this PR focusing on:
+                  #   - For TypeScript files: Type safety and proper interface usage
+                  #   - For API endpoints: Security, input validation, and error handling
+                  #   - For React components: Performance, accessibility, and best practices
+                  #   - For tests: Coverage, edge cases, and test quality
+
+                  # Optional: Different prompts for different authors
+                  # direct_prompt: |
+                  #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' &&
+                  #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
+                  #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
+
+                  # Optional: Add specific tools for running tests or linting
+                  # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
+
+                  # Optional: Skip review for certain conditions
+                  # if: |
+                  #   !contains(github.event.pull_request.title, '[skip-review]') &&
+                  #   !contains(github.event.pull_request.title, '[WIP]')

.github/workflows/claude.yml

@@ -1,64 +1,63 @@
 name: Claude Code
 
 on:
-  issue_comment:
-    types: [created]
-  pull_request_review_comment:
-    types: [created]
-  issues:
-    types: [opened, assigned]
-  pull_request_review:
-    types: [submitted]
+    issue_comment:
+        types: [created]
+    pull_request_review_comment:
+        types: [created]
+    issues:
+        types: [opened, assigned]
+    pull_request_review:
+        types: [submitted]
 
 jobs:
-  claude:
-    if: |
-      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
-      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
-      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
-      (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      pull-requests: read
-      issues: read
-      id-token: write
-      actions: read # Required for Claude to read CI results on PRs
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 1
+    claude:
+        if: |
+            (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
+            (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
+            (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
+            (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
+        runs-on: ubuntu-latest
+        permissions:
+            contents: read
+            pull-requests: write
+            issues: read
+            id-token: write
+            actions: read # Required for Claude to read CI results on PRs
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+              with:
+                  fetch-depth: 1
 
-      - name: Run Claude Code
-        id: claude
-        uses: anthropics/claude-code-action@beta
-        with:
-          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+            - name: Run Claude Code
+              id: claude
+              uses: anthropics/claude-code-action@beta
+              with:
+                  claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
-          # This is an optional setting that allows Claude to read CI results on PRs
-          additional_permissions: |
-            actions: read
-          
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
-          # model: "claude-opus-4-20250514"
-
-          # Optional: Customize the trigger phrase (default: @claude)
-          # trigger_phrase: "/claude"
-
-          # Optional: Trigger when specific user is assigned to an issue
-          # assignee_trigger: "claude-bot"
-
-          # Optional: Allow Claude to run specific commands
-          # allowed_tools: "Bash(npm install),Bash(npm run build),Bash(npm run test:*),Bash(npm run lint:*)"
-
-          # Optional: Add custom instructions for Claude to customize its behavior for your project
-          # custom_instructions: |
-          #   Follow our coding standards
-          #   Ensure all new code has tests
-          #   Use TypeScript for new files
-
-          # Optional: Custom environment variables for Claude
-          # claude_env: |
-          #   NODE_ENV: test
+                  # This is an optional setting that allows Claude to read CI results on PRs
+                  additional_permissions: |
+                      actions: read
 
+                  # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
+                  # model: "claude-opus-4-20250514"
+
+                  # Optional: Customize the trigger phrase (default: @claude)
+                  # trigger_phrase: "/claude"
+
+                  # Optional: Trigger when specific user is assigned to an issue
+                  # assignee_trigger: "claude-bot"
+
+                  # Optional: Allow Claude to run specific commands
+                  # allowed_tools: "Bash(npm install),Bash(npm run build),Bash(npm run test:*),Bash(npm run lint:*)"
+
+                  # Optional: Add custom instructions for Claude to customize its behavior for your project
+                  # custom_instructions: |
+                  #   Follow our coding standards
+                  #   Ensure all new code has tests
+                  #   Use TypeScript for new files
+
+                  # Optional: Custom environment variables for Claude
+                  # claude_env: |
+                  #   NODE_ENV: test

TODO.md

@@ -49,7 +49,7 @@
         - [x] Nested to-one
         - [x] Incremental update for numeric fields
         - [x] Array update
-        - [ ] Strict typing for checked/unchecked input
+        - [x] Strict typing for checked/unchecked input
     - [x] Upsert
         - [ ] Implement with "on conflict"
     - [x] Delete
@@ -73,7 +73,7 @@
         - [ ] Cross field comparison
         - [x] Many-to-many relation
         - [ ] Empty AND/OR/NOT behavior
-        - [?] Logging
+        - [x] Logging
         - [x] Error system
         - [x] Custom table name
         - [x] Custom field name
@@ -84,7 +84,10 @@
     - [ ] Post-mutation hooks should be called after transaction is committed
 - [x] TypeDef and mixin
 - [ ] Strongly typed JSON
-- [ ] Polymorphism
+- [x] Polymorphism
+    - [x] ZModel
+    - [x] Runtime
+    - [x] Typing
 - [ ] Validation
 - [ ] Access Policy
     - [ ] Short-circuit pre-create check for scalar-field only policies

packages/runtime/src/client/query-utils.ts

@@ -293,12 +293,7 @@ export function extractFields(object: any, fields: string[]) {
 
 export function extractIdFields(entity: any, schema: SchemaDef, model: string) {
     const idFields = getIdFields(schema, model);
-    return idFields.reduce((acc: any, field) => {
-        if (field in entity) {
-            acc[field] = entity[field];
-        }
-        return acc;
-    }, {});
+    return extractFields(entity, idFields);
 }
 
 export function getDiscriminatorField(schema: SchemaDef, model: string) {

packages/runtime/src/client/result-processor.ts

@@ -53,7 +53,7 @@ export class ResultProcessor<Schema extends SchemaDef> {
                         delete data[key];
                         continue;
                     }
-                    const processedSubRow = this.processRow(subRow, subRow);
+                    const processedSubRow = this.processRow(subRow, subModel);
 
                     // merge the sub-row into the main row
                     Object.assign(data, processedSubRow);