chore: add publish/unpublish preview scripts #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. ## Walkthrough
Two new npm scripts, `publish-preview` and `unpublish-preview`, were introduced in the `package.json` to manage package publishing and unpublishing to a custom preview registry. The `test` script entry was also updated with a trailing comma to maintain proper formatting. The CLI package name was changed from `"@zenstackhq/cli"` to `"zenstack"`. The `pnpm-workspace.yaml` was narrowed to explicitly include `language`, `sdk`, `runtime`, `cli`, and `testtools` packages instead of all. The `turbo.json` tasks were renamed and redefined: `"check-types"` became `"lint"`, and `"dev"` was replaced by `"test"`.
## Changes
| File | Change Summary |
|---------------------------|------------------------------------------------------------------------------------------------------------|
| package.json | Added `publish-preview` and `unpublish-preview` scripts; updated `test` script formatting. |
| packages/cli/package.json | Changed package name from `"@zenstackhq/cli"` to `"zenstack"`. |
| pnpm-workspace.yaml | Scoped workspace to explicitly include `language`, `sdk`, `runtime`, `cli`, and `testtools` packages instead of all. |
| turbo.json | Renamed and redefined tasks: `"check-types"` → `"lint"`; `"dev"` → `"test"`. |
| samples/blog/package.json | Updated dependency from `"@zenstackhq/cli"` to `"zenstack"` with version `"workspace:*"`. |
## Poem
> 🐇
> Scripts hop in, a preview flight,
> Publish, unpublish—day and night.
> A registry new, for changes to show,
> Packages leap where carrots grow.
> With every run, a bunny’s cheer—
> “Preview’s ready, changes near!”
>📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
package.json (2)
11-11: Standardizepublish-previewflag ordering
For clarity and to match pnpm’s recommended syntax, move the recursive flag before the filter and publish command:- "publish-preview": "pnpm --filter \"./packages/**\" -r publish --force --registry https://preview.registry.zenstack.dev/", + "publish-preview": "pnpm -r --filter \"./packages/**\" publish --force --registry https://preview.registry.zenstack.dev/",
12-12: Unifyunpublish-previewwith pnpm filter syntax
Align with thepublish-previewpattern by using the filter flag and consistent ordering:- "unpublish-preview": "pnpm --recursive --shell-mode exec -- npm unpublish -f --registry https://preview.registry.zenstack.dev/ \"\\$PNPM_PACKAGE_NAME\"" + "unpublish-preview": "pnpm -r --filter \"./packages/**\" --shell-mode exec -- npm unpublish -f --registry https://preview.registry.zenstack.dev/ \"\\$PNPM_PACKAGE_NAME\""
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-test (20.x)
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
package.json(1 hunks)packages/cli/package.json(1 hunks)pnpm-workspace.yaml(1 hunks)turbo.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/cli/package.json
- pnpm-workspace.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-test (20.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit