fix: don't inherit inherited map attribute

[dhritcu]

Resolves #291

Summary by CodeRabbit

• Bug Fixes
  • Corrected Prisma schema generation to ignore inherited mapping attributes from base models, preventing unintended propagation of @@Map. This eliminates duplicate or invalid mappings in generated schemas, reducing validation and migration errors and producing more predictable output.

[coderabbitai]

Walkthrough

The PrismaSchemaGenerator now filters model attributes to exclude inherited @@Map attributes from base models. A new private helper, isInheritedMapAttribute, detects map attributes originating from a different container. Attribute generation uses this guard to include only Prisma attributes relevant to the current model context.

Changes

Cohort / File(s)	Summary
Prisma schema generation filtering packages/sdk/src/prisma/prisma-schema-generator.ts	Added isInheritedMapAttribute helper and updated attribute processing in generateModel to skip inherited @@Map attributes; ensures only current-context Prisma attributes are emitted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitched my whiskers, sifted the hay,
Skipped the maps that wandered away—
Only the local glyphs may stay.
In Prisma fields I hop and play,
Guarding context, come what may.
Thump! Clean schemas lead the way. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the core change of preventing inherited map attributes from being applied by indicating “don’t inherit inherited map attribute,” which aligns directly with the code updates filtering out inherited @@Map attributes in the PrismaSchemaGenerator. It concisely reflects the fix without introducing unrelated details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/sdk/src/prisma/prisma-schema-generator.ts (1)

190-197: Implementation correctly identifies inherited @@map attributes.

The logic properly checks if an attribute is inherited (different container) and is specifically a @@map attribute. The nullish coalescing operator safely handles cases where the reference is unresolved.

Consider adding JSDoc to explain why only @@map is filtered among inherited attributes:

+    /**
+     * Checks if an attribute is an inherited @@map attribute.
+     * @@map attributes define table names and should not be inherited
+     * from base models, as each model should have its own table mapping.
+     */
     private isInheritedMapAttribute(attr: DataModelAttribute, contextModel: DataModel) {

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35a9e0d and 0bf7a4f.

📒 Files selected for processing (1)

• packages/sdk/src/prisma/prisma-schema-generator.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

{packages,samples,tests}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place packages only under packages/, samples/, or tests/

Files:

• packages/sdk/src/prisma/prisma-schema-generator.ts

🧬 Code graph analysis (1)

packages/sdk/src/prisma/prisma-schema-generator.ts (2)

packages/language/src/generated/ast.ts (4)

• DataModelAttribute (395-400)
• DataModelAttribute (402-402)
• DataModel (377-387)
• DataModel (389-389)

packages/language/src/ast.ts (1)

• DataModel (49-54)

🔇 Additional comments (1)

packages/sdk/src/prisma/prisma-schema-generator.ts (1)

174-176: Filtering logic correctly excludes inherited @@map; no other inherited model-level attributes detected.

[ymc9]

LGTM! Thanks for making the fix, @dhritcu