chore: test refactor #303
Merged
chore: test refactor #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughStandardizes regression tests by wrapping them in describe blocks and updating Vitest imports. Minor adjustments in a few tests (schema tweaks, assertion placement). Adds a debug?: boolean option to test client to gate logging. Performs whitespace-only formatting in ts-schema-generator and adjusts string literal formatting in a CLI test. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @ymc9's task —— View job PR Review: Test RefactorTodo List:
Review SummaryThis is a well-executed test refactoring that improves code organization and maintainability. The changes are systematic and consistent across 87 files. ✅ Positive Aspects1. Excellent Test Organization
2. Clean Code Improvements
3. Comprehensive Coverage
🔍 Code Quality AssessmentSecurity ✅
Performance ✅
Best Practices ✅
Maintainability ✅
📊 Test Coverage
🎯 RecommendationsMinor Suggestions:
🏆 Overall AssessmentGrade: A+ This is exemplary refactoring work that:
The systematic approach to updating 87 files while maintaining consistency demonstrates excellent attention to detail. This refactoring will make the test suite more maintainable and provide better developer experience when running tests. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors regression tests to group cases under describe blocks for clarity, updates a schema generator test to reflect formatting changes, and adds a debug option to the test client for easier troubleshooting.
- Wraps each regression test file in a describe(...) suite and updates Vitest imports accordingly.
- Adds a debug flag to CreateTestClientOptions and conditionally logs the work directory in createTestClient.
- Adjusts ts-schema generator output formatting and aligns related test expectations (e.g., quotes, trailing commas).
Reviewed Changes
Copilot reviewed 87 out of 87 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/regression/test/v2-migrated/issue-971.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-947.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-825.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-811.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-804.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-765.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-764.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-756.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-735.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-714.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-689.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-674.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-646.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-632.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-609.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-509.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-416.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-392.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-389.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2247.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2246.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2106.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2039.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2038.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2028.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2025.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-2019.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1998.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1997.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1994.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1992.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1991.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1930.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1894.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1870.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1857.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1849.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1835.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1786.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-177.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1763.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1758.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1755.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1745.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1698.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1695.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1693.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1681.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1674.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1648.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1645.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1642.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1627.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1585.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1576.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1575.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1563.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1562.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1551.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1530.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1522.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1520.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1518.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1507.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1506.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1487.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1483.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1467.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1427.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1416.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1415.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1410.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1388.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1381.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1271.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1257.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1241.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1179.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1167.test.ts | Wrap test in describe and import describe from vitest |
| tests/regression/test/v2-migrated/issue-1149.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1135.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1123.test.ts | Wrap test in describe and adjust expect formatting |
| tests/regression/test/v2-migrated/issue-1080.test.ts | Wrap test in describe and import describe/expect from vitest |
| tests/regression/test/v2-migrated/issue-1058.test.ts | Wrap test in describe and import describe from vitest |
| packages/testtools/src/client.ts | Add debug option to CreateTestClientOptions and conditional workDir logging |
| packages/sdk/src/ts-schema-generator.ts | Tweak array literal expression generation formatting for default call args |
| packages/cli/test/ts-schema-gen.test.ts | Update expected schema AST formatting (quotes, trailing commas) to match generator |
Comments suppressed due to low confidence (1)
packages/testtools/src/client.ts:1
- The new debug option is public API but lacks documentation. Please add a JSDoc comment describing its purpose (e.g., 'When true, logs the temporary work directory and other debug info during client setup') to CreateTestClientOptions and, if applicable, update any usage docs.
import { invariant } from '@zenstackhq/common-helpers';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (11)
tests/regression/test/v2-migrated/issue-1755.test.ts (1)
10-10: Minor: Inconsistent spacing in schema field definition.The
contentsfield has extra whitespace before the type annotation. For consistency with the rest of the schema, use a single space.Apply this diff to align the spacing:
- contents Content[] + contents Content[]tests/regression/test/v2-migrated/issue-1627.test.ts (1)
4-51: Test structure refactor looks good.The test is now properly wrapped in a describe block, which standardizes the regression test format as intended. The test logic remains functionally equivalent—it correctly verifies that without authentication context, the policy denies access to GymUser records (hence the expected length of 0).
Consider making the test description more informative:
- it('verifies issue 1627', async () => { + it('should enforce read policy when auth context is missing', async () => {This would make the test's purpose clearer without needing to reference the issue number.
tests/regression/test/v2-migrated/issue-1870.test.ts (1)
1-16: LGTM! Test refactoring aligns with PR objectives.The changes successfully wrap the regression test in a describe block and update the Vitest imports as intended. The test structure is now standardized and the logic remains unchanged.
Optional improvement: Consider a more descriptive test name that clarifies what issue #1870 was about. For example, if the issue was about parsing Unsupported types with Gist indexes, you could use:
- it('verifies issue 1870', async () => { + it('parses schema with Unsupported geometry type and Gist index', async () => {This would make the test's purpose clearer without needing to look up the issue number.
tests/regression/test/v2-migrated/issue-1507.test.ts (1)
4-26: Test logic is correct; consider optional cleanup.The describe block wrapper aligns perfectly with the PR objective. The test logic correctly verifies that the access control rule
@@allow('read', auth().age == age)filters profiles based on age matching.Optionally, consider the following refinements:
- The
Usermodel (lines 8-11) is defined but never used in the test. If it's not required to reproduce issue #1507, it could be removed.- The test name "verifies issue 1507" could be more descriptive (e.g., "filters profiles by matching age in access control rule").
tests/regression/test/v2-migrated/issue-1698.test.ts (1)
45-69: Consider removing debug console.log statements.The test contains six
console.logstatements that may clutter test output. Since this PR is focused on test refactoring, consider removing these debug statements or gating them behind a debug flag for cleaner test output.Example cleanup:
- console.log(door1); - const door2 = await db.woodenDoor.create({ data: { texture: 'pine', color: 'red' }, }); - console.log(door2); - const house1 = await db.privateHouse.create({ data: { size: 5000, door: { connect: { id: door1.id } } }, }); - console.log(house1); - const house2 = await db.skyscraper.create({ data: { height: 3000, door: { connect: { id: door2.id } } }, }); - console.log(house2); const r1 = await db.privateHouse.findFirst({ include: { door: true } }); - console.log(r1); expect(r1).toMatchObject({ door: { color: 'blue', strength: 100 }, }); const r2 = (await db.skyscraper.findMany({ include: { door: true } }))[0]; - console.log(r2); expect(r2).toMatchObject({tests/regression/test/v2-migrated/issue-1645.test.ts (1)
4-5: Consider a more descriptive test name.The describe and it block structure follows Vitest conventions. However, the it block description "verifies issue 1645" could be more specific about what behavior is being tested (e.g., "should preserve address relations after order type update").
Apply this diff for a more descriptive test name:
- it('verifies issue 1645', async () => { + it('should preserve address relations after order type update', async () => {tests/regression/test/v2-migrated/issue-1563.test.ts (1)
4-28: LGTM! Test structure properly refactored.The test is correctly wrapped in a
describeblock with a descriptive title, and the test logic is properly nested within anitblock. The refactoring maintains the original test behavior while improving organization.Optional improvement: Consider making the test name more descriptive of what it verifies:
- it('verifies issue 1563', async () => { + it('should allow update when validation rule passes', async () => {This would make the test's purpose clearer without needing to reference the issue number.
tests/regression/test/v2-migrated/issue-1991.test.ts (1)
4-5: Test structure correctly refactored.The describe/it block structure properly standardizes this regression test. The test name "verifies issue 1991" is acceptable, though you might consider a more descriptive name like "verifies JSON field type generation for composite types" to clarify what aspect of issue #1991 is being tested.
tests/regression/test/v2-migrated/issue-1135.test.ts (1)
32-49: Consider removing the unused extraSourceFiles.The
main.tscontent inextraSourceFilesduplicates the test logic (lines 54-76) and appears to be unused. This could cause confusion about which code is actually being tested.If
extraSourceFilesis not required for this test, consider removing it:- { - extraSourceFiles: { - 'main.ts': ` -import { ZenStackClient } from '@zenstackhq/runtime'; -import { schema } from './schema'; - -const db = new ZenStackClient(schema, {} as any); - -db.person.create({ - data: { - name: 'test', - attachments: { - create: { - url: 'https://...', - }, - }, - }, -}); - `, - }, - },tests/regression/test/v2-migrated/issue-1271.test.ts (1)
126-127: Drop leftover debug loggingUnconditional
console.login regression tests adds noisy output to CI runs without providing value. Please remove it unless there’s a compelling reason to keep it.tests/regression/test/v2-migrated/issue-2025.test.ts (1)
31-38: Verify that the test still correctly covers issue #2025.The AI summary indicates this assertion was changed (not just indented). Ensure that using
toResolveTruthy()adequately verifies the fix for issue #2025. Consider whether a more specific assertion would better document the expected behavior, such as:- await expect( - db.user.update({ - where: { id: user.id }, - data: { - termsAndConditions: 1, - }, - }), - ).toResolveTruthy(); + const updated = await db.user.update({ + where: { id: user.id }, + data: { + termsAndConditions: 1, + }, + }); + expect(updated.termsAndConditions).toBe(1);This would verify not just that the update succeeds, but that the field was actually updated correctly.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (87)
packages/cli/test/ts-schema-gen.test.ts(1 hunks)packages/sdk/src/ts-schema-generator.ts(1 hunks)packages/testtools/src/client.ts(2 hunks)tests/regression/test/v2-migrated/issue-1058.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1080.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1123.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-1135.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-1149.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1167.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1179.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1241.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1257.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-1271.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1381.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1388.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1410.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1415.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1416.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1427.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1467.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1483.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1487.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1506.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1507.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1518.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1520.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1522.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1530.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1551.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1562.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1563.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1575.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1576.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1585.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1627.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1642.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1645.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1648.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1674.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1681.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1693.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1695.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1698.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1745.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1755.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1758.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1763.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-177.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1786.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1835.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1849.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1857.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-1870.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1894.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1930.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1991.test.ts(3 hunks)tests/regression/test/v2-migrated/issue-1992.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-1994.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1997.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-1998.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2019.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2025.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2028.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2038.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2039.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2106.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2246.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-2247.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-389.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-392.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-416.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-509.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-609.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-632.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-646.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-674.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-689.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-714.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-735.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-756.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-764.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-765.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-804.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-811.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-825.test.ts(1 hunks)tests/regression/test/v2-migrated/issue-947.test.ts(2 hunks)tests/regression/test/v2-migrated/issue-971.test.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
{packages,samples,tests}/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place packages only under
packages/,samples/, ortests/
Files:
packages/testtools/src/client.tspackages/sdk/src/ts-schema-generator.tstests/regression/test/v2-migrated/issue-1698.test.tspackages/cli/test/ts-schema-gen.test.tstests/regression/test/v2-migrated/issue-764.test.tstests/regression/test/v2-migrated/issue-947.test.tstests/regression/test/v2-migrated/issue-1849.test.tstests/regression/test/v2-migrated/issue-1991.test.tstests/regression/test/v2-migrated/issue-1576.test.tstests/regression/test/v2-migrated/issue-1415.test.tstests/regression/test/v2-migrated/issue-1870.test.tstests/regression/test/v2-migrated/issue-1487.test.tstests/regression/test/v2-migrated/issue-1745.test.tstests/regression/test/v2-migrated/issue-1506.test.tstests/regression/test/v2-migrated/issue-1681.test.tstests/regression/test/v2-migrated/issue-756.test.tstests/regression/test/v2-migrated/issue-804.test.tstests/regression/test/v2-migrated/issue-1416.test.tstests/regression/test/v2-migrated/issue-1994.test.tstests/regression/test/v2-migrated/issue-825.test.tstests/regression/test/v2-migrated/issue-971.test.tstests/regression/test/v2-migrated/issue-1674.test.tstests/regression/test/v2-migrated/issue-1507.test.tstests/regression/test/v2-migrated/issue-1241.test.tstests/regression/test/v2-migrated/issue-1467.test.tstests/regression/test/v2-migrated/issue-1992.test.tstests/regression/test/v2-migrated/issue-1835.test.tstests/regression/test/v2-migrated/issue-1257.test.tstests/regression/test/v2-migrated/issue-1575.test.tstests/regression/test/v2-migrated/issue-1645.test.tstests/regression/test/v2-migrated/issue-1755.test.tstests/regression/test/v2-migrated/issue-1642.test.tstests/regression/test/v2-migrated/issue-1763.test.tstests/regression/test/v2-migrated/issue-1388.test.tstests/regression/test/v2-migrated/issue-609.test.tstests/regression/test/v2-migrated/issue-1381.test.tstests/regression/test/v2-migrated/issue-2025.test.tstests/regression/test/v2-migrated/issue-1648.test.tstests/regression/test/v2-migrated/issue-1522.test.tstests/regression/test/v2-migrated/issue-1080.test.tstests/regression/test/v2-migrated/issue-1058.test.tstests/regression/test/v2-migrated/issue-1167.test.tstests/regression/test/v2-migrated/issue-509.test.tstests/regression/test/v2-migrated/issue-2039.test.tstests/regression/test/v2-migrated/issue-1483.test.tstests/regression/test/v2-migrated/issue-1585.test.tstests/regression/test/v2-migrated/issue-1758.test.tstests/regression/test/v2-migrated/issue-2038.test.tstests/regression/test/v2-migrated/issue-1998.test.tstests/regression/test/v2-migrated/issue-1149.test.tstests/regression/test/v2-migrated/issue-1551.test.tstests/regression/test/v2-migrated/issue-646.test.tstests/regression/test/v2-migrated/issue-2028.test.tstests/regression/test/v2-migrated/issue-1997.test.tstests/regression/test/v2-migrated/issue-1930.test.tstests/regression/test/v2-migrated/issue-2106.test.tstests/regression/test/v2-migrated/issue-1562.test.tstests/regression/test/v2-migrated/issue-1857.test.tstests/regression/test/v2-migrated/issue-1520.test.tstests/regression/test/v2-migrated/issue-1135.test.tstests/regression/test/v2-migrated/issue-389.test.tstests/regression/test/v2-migrated/issue-689.test.tstests/regression/test/v2-migrated/issue-674.test.tstests/regression/test/v2-migrated/issue-1786.test.tstests/regression/test/v2-migrated/issue-1894.test.tstests/regression/test/v2-migrated/issue-1627.test.tstests/regression/test/v2-migrated/issue-1271.test.tstests/regression/test/v2-migrated/issue-392.test.tstests/regression/test/v2-migrated/issue-1179.test.tstests/regression/test/v2-migrated/issue-1695.test.tstests/regression/test/v2-migrated/issue-714.test.tstests/regression/test/v2-migrated/issue-177.test.tstests/regression/test/v2-migrated/issue-632.test.tstests/regression/test/v2-migrated/issue-1427.test.tstests/regression/test/v2-migrated/issue-416.test.tstests/regression/test/v2-migrated/issue-1518.test.tstests/regression/test/v2-migrated/issue-2247.test.tstests/regression/test/v2-migrated/issue-811.test.tstests/regression/test/v2-migrated/issue-2019.test.tstests/regression/test/v2-migrated/issue-735.test.tstests/regression/test/v2-migrated/issue-1410.test.tstests/regression/test/v2-migrated/issue-1530.test.tstests/regression/test/v2-migrated/issue-2246.test.tstests/regression/test/v2-migrated/issue-765.test.tstests/regression/test/v2-migrated/issue-1693.test.tstests/regression/test/v2-migrated/issue-1563.test.tstests/regression/test/v2-migrated/issue-1123.test.ts
🧬 Code graph analysis (69)
packages/testtools/src/client.ts (1)
packages/runtime/src/client/crud/operations/base.ts (1)
options(94-96)
tests/regression/test/v2-migrated/issue-1698.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-764.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1849.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1991.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1576.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1415.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1870.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1487.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1745.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1506.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1681.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1416.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1994.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-825.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1674.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1507.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1241.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1835.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1257.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1645.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1642.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1763.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1388.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-609.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1381.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-2025.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1648.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1080.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1058.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1167.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-509.test.ts (1)
packages/language/src/index.ts (1)
loadDocument(21-136)
tests/regression/test/v2-migrated/issue-2039.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1483.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1758.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchemaWithError(126-148)
tests/regression/test/v2-migrated/issue-2038.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1998.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1149.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-646.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-2028.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1997.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1930.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-2106.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1562.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1857.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1520.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-389.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-689.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1786.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1894.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1627.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1271.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-392.test.ts (1)
packages/language/src/index.ts (1)
loadDocument(21-136)
tests/regression/test/v2-migrated/issue-1179.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1695.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-714.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-177.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchemaWithError(126-148)
tests/regression/test/v2-migrated/issue-632.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-416.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1518.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-811.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-2019.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1410.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1530.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-2246.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-765.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
tests/regression/test/v2-migrated/issue-1693.test.ts (1)
packages/testtools/src/schema.ts (1)
loadSchema(94-124)
tests/regression/test/v2-migrated/issue-1563.test.ts (1)
packages/testtools/src/client.ts (1)
createTestClient(52-169)
tests/regression/test/v2-migrated/issue-1123.test.ts (1)
packages/testtools/src/client.ts (1)
createPolicyTestClient(179-190)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: claude-review
- GitHub Check: build-test (20.x, sqlite)
- GitHub Check: build-test (20.x, postgresql)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests
Style