-
-
Notifications
You must be signed in to change notification settings - Fork 12
chore(cli): improve help text of migrate reset #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds help text to the reset migrate subcommand in the CLI to inform users that a seed script defined in package.json will be run after reset, unless the --skip-seed flag is used. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @ymc9's task —— View job PR Review: Improve help text of migrate resetReview Checklist:
Review SummaryThis PR adds helpful clarification text to the Detailed Analysis✅ Code Quality & Best Practices
✅ No Bugs or Issues Detected
✅ Performance Considerations
✅ Security Concerns
📋 Test Coverage ConsiderationsThe existing test in it('should display help text for migrate reset', () => {
const output = runCliCapture('migrate reset --help', workDir);
expect(output).toContain('If there is a seed script defined in package.json');
expect(output).toContain('Use --skip-seed to skip it');
});However, this is not required as help text testing is often considered lower priority than functional testing. Minor Suggestions
Overall Assessment✅ APPROVED - This is a clean, straightforward improvement that enhances user experience without any negative impacts. The change is well-implemented and follows existing patterns in the codebase. The addition provides valuable context to users about the seeding behavior after reset operations, which is exactly the kind of helpful documentation that improves CLI usability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the user experience by adding contextual help text to the migrate reset command, clarifying the default seeding behavior and how to skip it.
- Adds
.addHelpText()call to themigrate resetcommand to provide additional usage information
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/cli/src/index.ts (1)
97-100: Help text update is clear and correctly wired tomigrate reset.The
addHelpText('after', ...)usage is correct for Commander, and the message accurately reflects the--skip-seedflag behavior. Optionally, you might reference thezenstack.seedconfig (as in thedb seedhelp text) for consistency, but the current wording is already serviceable.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/cli/src/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: claude-review
- GitHub Check: build-test (20.x, postgresql)
- GitHub Check: build-test (20.x, sqlite)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.