-
-
Notifications
You must be signed in to change notification settings - Fork 12
fix: schema generation for unsupported field type #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes schema generation for unsupported field types by updating the TS schema generator and associated types while adding tests to validate the changes.
- Updates field type literal mapping to handle unsupported types.
- Refines default value conversion logic to properly handle array literals.
- Adds e2e tests for schema generation changes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/formbricks/schema.zmodel | New comprehensive schema file used for testing the unsupported field type handling. |
| tests/e2e/formbricks/formbricks.test.ts | Added a test validating schema generation for the Formbricks schema. |
| tests/e2e/cal.com/cal-com.test.ts | Updated test to use promise assertions for schema generation consistency. |
| packages/sdk/src/ts-schema-generator.ts | Modified field type literal generation and default value handling to support array literals. |
| packages/sdk/src/schema/schema.ts | Extended the type for default field values to allow array defaults. |
Comments suppressed due to low confidence (1)
packages/sdk/src/schema/schema.ts:62
- Ensure that downstream code consuming this type can handle the addition of array defaults without unexpected issues.
default?: MappedBuiltinType | Expression | unknown[];
No description provided.