-
-
Notifications
You must be signed in to change notification settings - Fork 12
fix: make create's typing consistent with Prisma regarding to relations #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aligns the create API’s TypeScript definitions with Prisma’s checked vs. unchecked relation semantics.
- Introduce separate “checked” and “unchecked” schema variants in the input validator
- Rename and refactor
CreateManytypes toCreateManyInputand extend create-types to include non‐owned relations - Add a compile‐time test to verify Prisma‐compatible typing for owned vs. foreign‐key relations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/runtime/test/client-api/create.test.ts | Added a TS‐compile test for mutually exclusive FK vs. owned relation and for non‐owned relations |
| packages/runtime/src/client/crud/validator.ts | Replaced regularAnd* maps with uncheckedVariantFields/checkedVariantFields and updated logic |
| packages/runtime/src/client/crud-types.ts | Renamed CreateMany types, added CreateWithNonOwnedRelationPayload, and defined NonOwnedRelationFields |
Comments suppressed due to low confidence (2)
packages/runtime/src/client/crud-types.ts:1094
- [nitpick] Add a brief comment explaining the purpose of the
NonOwnedRelationFieldsutility type to clarify that it extracts relation fields without foreign key references.
type NonOwnedRelationFields<Schema extends SchemaDef, Model extends GetModels<Schema>> = keyof {
packages/runtime/src/client/crud-types.ts:611
- [nitpick] Consider renaming
CreateWithNonOwnedRelationPayloadtoCreateNonOwnedRelationInput(or similar) to align with existingCreateWithRelationInputnaming patterns and improve consistency.
type CreateWithNonOwnedRelationPayload<Schema extends SchemaDef, Model extends GetModels<Schema>> = OptionalWrap<
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.