perf: improve tsc performance for runtime project

[ymc9]

Summary by CodeRabbit

• Refactor
  • Improved internal type handling for better TypeScript compilation performance and simplified type mapping logic.
• Style
  • Added explicit type annotations in test cases for clarity.

[coderabbitai]

Walkthrough

The changes introduce explicit generic type parameters to operation handler instantiations in the client implementation, refactor a utility type using a mapped object for cleaner type mapping, and add explicit any typing to a parameter in computed field test cases. No exported signatures or logic are altered.

Changes

File(s)	Change Summary
packages/runtime/src/client/client-impl.ts	Added explicit <Schema> generic type parameters to all operation handler instantiations within createModelCrudHandler.
packages/runtime/src/utils/type-utils.ts	Refactored MapBaseType to use a mapped object TypeMap for type mapping, replacing nested conditional types.
packages/runtime/test/client-api/computed-fields.test.ts	Added explicit any typing to the eb parameter in computed field test cases.

Possibly related PRs

• zenstackhq/zenstack-v3#87: Also modifies client-impl.ts, focusing on fixing a misspelled import and usage of GroupByOperationHandler, closely related as it involves the same file and handler classes.

Poem

In the warren of code, a rabbit hopped quick,
Tidying types with a mapping so slick.
Generics declared, handlers now clear,
Test fields typed for all to cheer!
With every hop, the code grows bright—
🐇✨ TypeScript dreams take flight!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/runtime/src/client/client-impl.ts

Oops! Something went wrong! :(

ESLint: 9.29.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

packages/runtime/src/utils/type-utils.ts

Oops! Something went wrong! :(

ESLint: 9.29.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

packages/runtime/test/client-api/computed-fields.test.ts

Oops! Something went wrong! :(

ESLint: 9.29.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64cfad0 and a68a669.

📒 Files selected for processing (3)

• packages/runtime/src/client/client-impl.ts (1 hunks)
• packages/runtime/src/utils/type-utils.ts (1 hunks)
• packages/runtime/test/client-api/computed-fields.test.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/runtime/src/utils/type-utils.ts (2)

packages/runtime/src/index.ts (1)

• JsonValue (2-2)

packages/runtime/src/client/query-builder.ts (1)

• MapBaseType (28-40)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-test (20.x)

🔇 Additional comments (9)

packages/runtime/src/utils/type-utils.ts (1)

25-37: Excellent refactoring for TypeScript compiler performance!

The replacement of nested conditional types with a mapped object type (TypeMap) is a smart optimization. This approach reduces compilation complexity and improves type resolution performance by allowing the compiler to resolve type mappings in fewer steps compared to the previous deeply nested conditional structure.

packages/runtime/test/client-api/computed-fields.test.ts (2)

17-17: Good explicit typing for compiler performance.

Adding explicit any typing to the eb parameter eliminates type inference overhead and contributes to the TypeScript compilation performance improvements targeted by this PR.

---

93-93: Consistent explicit typing improvement.

Same performance benefit as the previous change - explicit typing reduces compiler inference work.

packages/runtime/src/client/client-impl.ts (6)

414-414: Clear documentation of performance optimization intent.

The comment effectively explains why explicit type parameters are being added throughout this function, aligning with the PR's goal of improving TypeScript compiler performance.

---

420-420: Consistent explicit typing for FindOperationHandler instances.

Adding explicit <Schema> generic type parameters eliminates type inference overhead and improves compilation performance. The consistent application across all FindOperationHandler instantiations is excellent.

Also applies to: 429-429, 439-439, 448-448, 458-458

---

467-467: Proper explicit typing for CreateOperationHandler instances.

Same performance optimization pattern applied consistently to CreateOperationHandler instantiations.

Also applies to: 476-476, 485-485

---

494-494: Systematic optimization for UpdateOperationHandler instances.

Explicit generic type parameters consistently applied to all UpdateOperationHandler instantiations, supporting the compilation performance goals.

Also applies to: 503-503, 512-512, 521-521

---

530-530: Complete coverage for DeleteOperationHandler instances.

The explicit typing pattern is properly applied to DeleteOperationHandler instantiations as well.

Also applies to: 539-539

---

548-548: Final operation handlers properly optimized.

CountOperationHandler, AggregateOperationHandler, and GroupByOperationHandler all receive the same explicit generic type parameter treatment, completing the systematic performance optimization across all operation handlers.

Also applies to: 557-557, 563-563

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR aims to boost TypeScript compilation performance in the runtime project by making type parameters explicit and streamlining type mappings.

• Annotate operation handlers with <Schema> to reduce compiler inference overhead.
• Refactor createPromise calls to multi-line formatting for readability.
• Replace a long conditional union in MapBaseType with a concise TypeMap lookup.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/runtime/test/client-api/computed-fields.test.ts	Added any annotations on eb callbacks in computed fields tests
packages/runtime/src/utils/type-utils.ts	Swapped union-based MapBaseType for a TypeMap mapping
packages/runtime/src/client/client-impl.ts	Added <Schema> generics to each operation handler and expanded createPromise calls

Comments suppressed due to low confidence (3)

packages/runtime/test/client-api/computed-fields.test.ts:17

• Using any for the eb parameter weakens type safety in your tests. Consider importing and using the correct ExpressionBuilder type (or a typed stub) instead of any.

                        upperName: (eb: any) => eb.fn('upper', ['name']),

packages/runtime/test/client-api/computed-fields.test.ts:93

• Similar to above, avoid any on the eb parameter. Use the actual builder type or a minimal mock interface to keep the test type-checked.

                        upperName: (eb: any) => eb.lit(null),

packages/runtime/src/client/client-impl.ts:417

• [nitpick] This pattern of calling createPromise with a new handler is repeated across many methods. Consider extracting a helper function that takes the operation name and handler class to reduce boilerplate and ease future updates.

            return createPromise(

[ymc9]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.