fix: make datasource url optional #2305

ymc9 · 2025-11-19T18:11:55Z

No description provided.

coderabbitai · 2025-11-19T18:12:05Z

📝 Walkthrough

Walkthrough

Validator behavior changed: when a DataSource is missing the url field, validation now returns early (treating url as optional for newer Prisma versions) instead of emitting an error; other url and shadowDatabaseUrl validation logic remains unchanged. Tests and some integration test package pins were updated accordingly.

Changes

Cohort / File(s)	Summary
DataSource validator URL handling `packages/schema/src/language-server/validator/datasource-validator.ts`	Added an early return when a DataSource `url` field is missing (making `url` optional for newer Prisma versions); preserved remaining `url` / `shadowDatabaseUrl` validation logic.
Datasource validation test update `packages/schema/tests/schema/validation/datasource-validation.test.ts`	Adjusted test expectation for missing fields: rejection reason no longer includes a `url` error and now reports only the provider message.
Generator test Prisma pinning `packages/schema/tests/generator/prisma-generator.test.ts`	Pinned the Prisma package in the test setup command to `prisma@6.19.x` (was unpinned).
Integration test dependency pinning `tests/integration/tests/cli/generate.test.ts`	Pinned installed packages in test setup to `prisma@6.19.x` and `@prisma/client@6.19.x` (previously unpinned installs).

Sequence Diagram(s)

sequenceDiagram
  participant SchemaAST as Schema AST
  participant Validator as DataSource Validator
  rect rgba(220,235,255,0.6)
    note right of SchemaAST: Incoming DataSource node
  end

  SchemaAST->>Validator: validateDataSource(node)
  alt url field present
    Validator->>Validator: validate url and shadowDatabaseUrl
    Validator-->>SchemaAST: emit errors/warnings (if any)
  else url field missing (OLD)
    Validator->>Validator: emit error ("url field missing")
    Validator-->>SchemaAST: emit error
  else url field missing (NEW)
    Validator-->>SchemaAST: return early (no url error)
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

Review placement of the early return to ensure other validations (especially shadowDatabaseUrl and downstream checks) remain executed when appropriate.
Verify unit/integration tests reflect the intended behavior and that error messages/expectations were adjusted correctly.
Confirm the pinned Prisma versions in tests do not unintentionally change test outcomes or CI environments.

Possibly related PRs

chore: use prisma 6.17 in tests #2287 — Modifies the same datasource-validation tests and related validator behavior.
chore: upgrade to Prisma 5.14.0 #1477 — Also adjusts datasource validation behavior and test expectations for missing datasource fields.
chore: prisma 6.8 support #2118 — Updates Prisma package version pins in test setups, similar to the dependency pinning here.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining why the URL field is now optional and any compatibility notes with newer Prisma versions.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: making the datasource URL optional in the validator.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/datasource-url-optional

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2e2024 and fcbd538.

📒 Files selected for processing (1)

packages/schema/src/language-server/validator/datasource-validator.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build-test (20.x)
GitHub Check: build-test (20.x)
GitHub Check: dependency-review
GitHub Check: build-test (20.x)

packages/schema/src/language-server/validator/datasource-validator.ts

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/schema/tests/schema/validation/datasource-validation.test.ts (1)
83-99: Add test coverage for optional url scenario.

The success tests all include the url field. Consider adding a test case that validates a datasource with only the provider field (no url) to ensure the optional url feature works correctly:
it('success without url', async () => {
    await loadModel(`
        datasource db {
            provider = "postgresql"
        }
    `);
});

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcbd538 and e5d8a1f.

📒 Files selected for processing (2)

packages/schema/tests/schema/validation/datasource-validation.test.ts (1 hunks)
tests/integration/tests/cli/generate.test.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

tests/integration/tests/cli/generate.test.ts (1)

packages/testtools/src/schema.ts (1)

installPackage (68-70)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build-test (20.x)
GitHub Check: build-test (20.x)
GitHub Check: dependency-review
GitHub Check: build-test (20.x)

🔇 Additional comments (2)

packages/schema/tests/schema/validation/datasource-validation.test.ts (1)

13-13: The test change is correct and verified.

The validator implementation confirms that the url field is optional. In the validateUrl() method (lines 40-48), when the url field is not present, the validator returns early without raising an error. The validateProvider() method remains the only validator that will produce an error when the provider field is missing.

The test now correctly expects a single error message about the missing provider field, which aligns with the validator's behavior where only the provider is required.

tests/integration/tests/cli/generate.test.ts (1)

48-48: The review comment is based on an incorrect premise and should be disregarded.

Prisma 6.19 does not support optional datasource URLs—the url field is required in Prisma 6.x. The test schema itself explicitly provides a datasource URL (url = "file:./dev.db"), so it does not depend on optional URL support. The reason for pinning to version 6.19.x remains undocumented in the code, but it is not for optional URL field support as the original review suggested.

Likely an incorrect or invalid review comment.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5d8a1f and f3d8716.

📒 Files selected for processing (1)

packages/schema/tests/generator/prisma-generator.test.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

packages/schema/tests/generator/prisma-generator.test.ts (1)

packages/schema/src/utils/exec-utils.ts (1)

execSync (6-10)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build-test (20.x)
GitHub Check: dependency-review
GitHub Check: build-test (20.x)
GitHub Check: build-test (20.x)

packages/schema/tests/generator/prisma-generator.test.ts

jamiter · 2025-11-20T21:00:45Z

FYI, for Prisma 7 the url has been deprecated completely and this change is required to upgrade to v7.

ymc9 · 2025-11-20T21:02:11Z

Thanks @jamiter . The current plan is to not support v7 for ZenStack v2. I'll share this information with the next release and collect feedback.

fix: make datasource url optional

fcbd538

coderabbitai bot reviewed Nov 19, 2025

View reviewed changes

packages/schema/src/language-server/validator/datasource-validator.ts Show resolved Hide resolved

update tests

e5d8a1f

coderabbitai bot reviewed Nov 19, 2025

View reviewed changes

update tests

f3d8716

coderabbitai bot reviewed Nov 19, 2025

View reviewed changes

packages/schema/tests/generator/prisma-generator.test.ts Show resolved Hide resolved

ymc9 merged commit c23ff10 into dev Nov 19, 2025
8 checks passed

ymc9 deleted the fix/datasource-url-optional branch November 19, 2025 22:21

coderabbitai bot mentioned this pull request Nov 22, 2025

merge dev to main (v2.22.0) #2308

Merged

This was referenced Nov 24, 2025

Make enhance function compatible with prisma v7 #2310

Merged

Prisma 7 "url" field requirement #2309

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: make datasource url optional #2305

fix: make datasource url optional #2305

Uh oh!

ymc9 commented Nov 19, 2025

Uh oh!

coderabbitai bot commented Nov 19, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

jamiter commented Nov 20, 2025

Uh oh!

ymc9 commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: make datasource url optional #2305

fix: make datasource url optional #2305

Uh oh!

Conversation

ymc9 commented Nov 19, 2025

Uh oh!

coderabbitai bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jamiter commented Nov 20, 2025

Uh oh!

ymc9 commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Nov 19, 2025 •

edited

Loading