-
-
Notifications
You must be signed in to change notification settings - Fork 127
merge dev to main (v2.22.1) #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe PR includes a plugin version bump (2.22.0→2.22.1), modifies OpenAPI schema generation for Json fields with TypeDef arrays to use AST-based detection instead of DMMF, adds a corresponding test case, and hardcodes Prisma version support to "6" in the init action. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (13)
package.jsonis excluded by!**/*.jsonpackages/ide/jetbrains/package.jsonis excluded by!**/*.jsonpackages/language/package.jsonis excluded by!**/*.jsonpackages/misc/redwood/package.jsonis excluded by!**/*.jsonpackages/plugins/openapi/package.jsonis excluded by!**/*.jsonpackages/plugins/swr/package.jsonis excluded by!**/*.jsonpackages/plugins/tanstack-query/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/package.jsonis excluded by!**/*.jsonpackages/runtime/package.jsonis excluded by!**/*.jsonpackages/schema/package.jsonis excluded by!**/*.jsonpackages/sdk/package.jsonis excluded by!**/*.jsonpackages/server/package.jsonis excluded by!**/*.jsonpackages/testtools/package.jsonis excluded by!**/*.json
📒 Files selected for processing (4)
packages/ide/jetbrains/build.gradle.kts(1 hunks)packages/plugins/openapi/src/rpc-generator.ts(1 hunks)packages/plugins/openapi/tests/openapi-rpc.test.ts(1 hunks)packages/schema/src/cli/actions/init.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: dependency-review
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
🔇 Additional comments (3)
packages/ide/jetbrains/build.gradle.kts (1)
12-12: LGTM!Version bump to 2.22.1 is consistent with the release.
packages/plugins/openapi/src/rpc-generator.ts (1)
782-796: LGTM!Using the AST's
field.type.arrayinstead of DMMF'sdef.isListis the correct approach for Json fields referencing TypeDefs. Since Prisma treats these as plain Json in the DMMF, the ZModel AST is the source of truth for array information. The clarifying comment is helpful.packages/plugins/openapi/tests/openapi-rpc.test.ts (1)
521-578: LGTM!Excellent test coverage for arrays of TypeDefs with enums directly on model fields. The test validates the bug fix in
rpc-generator.tsby ensuring that:
- TypeDef and enum schemas are properly generated
- Cross-schema references work correctly
- Array semantics are preserved using AST-based detection
Testing across both OpenAPI 3.0.0 and 3.1.0 ensures compatibility.
No description provided.