Skip to content

fix: Support implicit many-to-many #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: Support implicit many-to-many #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421d3b6
fix: Support implicit many-to-many
jiashengguo Mar 21, 2023
a5910da
test: add many-to-many UT
jiashengguo Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/schema/src/language-server/validator/datamodel-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,18 @@ export default class DataModelValidator implements AstValidator<DataModel> {
relationOwner = field;
}
} else {
[field, oppositeField].forEach((f) => {
if (!this.isSelfRelation(f, thisRelation.name)) {
accept(
'error',
'Field for one side of relation must carry @relation attribute with both "fields" and "references" fields',
{ node: f }
);
}
});
// if both the field is array, then it's an implicit many-to-many relation
if (!(field.type.array && oppositeField.type.array)) {
[field, oppositeField].forEach((f) => {
if (!this.isSelfRelation(f, thisRelation.name)) {
accept(
'error',
'Field for one side of relation must carry @relation attribute with both "fields" and "references" fields',
{ node: f }
);
}
});
}
return;
}

Expand Down
17 changes: 17 additions & 0 deletions packages/schema/tests/schema/validation/datamodel-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,23 @@ describe('Data Model Validation Tests', () => {
}
`);

// many-to-many implicit
//https://www.prisma.io/docs/concepts/components/prisma-schema/relations/many-to-many-relations#implicit-many-to-many-relations
await loadModel(`
${prelude}
model Post {
id Int @id @default(autoincrement())
title String
categories Category[]
}

model Category {
id Int @id @default(autoincrement())
name String
posts Post[]
}
`);

// one-to-one incomplete
expect(
await loadModelWithError(`
Expand Down