Skip to content

Conversation

@flohw
Copy link
Contributor

@flohw flohw commented Feb 7, 2022

An simple attempt to fix #67

Tell me if I can improve something.

I tried to keep the regexes simple. It could be merged into one but the $matches array index handling would be harder depending on the case.

@flohw
Copy link
Contributor Author

flohw commented Feb 7, 2022

I just fixes phpcs on strtr. But as there is no test on BrowserExtension, I am not sure if I need to do something for the codecoverage alert.

@kbond
Copy link
Member

kbond commented Feb 8, 2022

Thanks for catching this edge case @flohw.

Don't worry about the code coverage - I only use it as a loose metric and this is a tough class to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Undefined array key 1 when the test failed

2 participants