Segmentation fault in dataprovider with PersistentProxyObjectFactory

[VincentLanglet]

Hi @nikophil, I saw you made #648 and I think I have an edge case.

I'm using foundry and phpunit, I have added the extension

<bootstrap class="Zenstruck\Foundry\PHPUnit\FoundryExtension" />

When using

DeploymentFactory::createOne()->getName();

in a Dataprovider of a TestCase (I didn't try a WebTestCase, my use case is a unit test ATM) I'm getting a segmentation fault.

This occurs with the following factory

final class DeploymentFactory extends PersistentProxyObjectFactory
{
    public static function class(): string
    {
        return Deployment::class;
    }

    /**
     * @return array<string, mixed>
     */
    protected function defaults(): array
    {
        $countryCode = self::faker()->countryCode();

        return [
            'id' => $countryCode,
            'name' => self::faker()->word(),
            'engineDomain' => 'api.'.$countryCode.'.weglot.com',
            'frontDomain' => 'app.'.$countryCode.'.weglot.com',
        ];
    }
}

As soon as I change the PersistentProxyObjectFactory into a PersistentObjectFactory the issue is solved.

[nikophil]

Hi @VincentLanglet

that's strange, because creating an object from a proxy factory in a data provider is a tested use case

would you mind to create a small reproducer, please?

[nikophil]

ok, forget about the reproducer, I know where it is coming from 😅

I'll fix this quickly

[VincentLanglet]

that's strange, because creating an object from a proxy factory in a data provider is a tested use case

would you mind to create a small reproducer, please?

Just call a getter on the entity.

You have a test with GenericProxyEntityFactory::createOne(), but not GenericProxyEntityFactory::createOne()->getFoo()

[nikophil]

yes, actually this should work in a TestCase and must be forbidden in a KernelTestCase

[VincentLanglet]

yes, actually this should work in a TestCase

Nice, it will solve my use case

and must be forbidden in a KernelTestCase

I dunno if an exception can be added for this usecase, (rather than the current segmentation fault ^^')

[nikophil]

yeah, I think that we could cover both use cases:

• in a unit test, allow to access the object in a data provider, even if using "proxy factories"
• in a kernel test case, trigger an exception, because it will try to trigger the persistence, and that's absolutely not what we want in a data provider 😅

BTW, I just tried it on my computer, and I didn't had a segfault, but it was acting as an infinite loop