variants: bunch all includes in common file #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhruvaG2000
force-pushed
the
fix/include-build-warns
branch
2 times, most recently
from
fd7394e to
ea681ae
Compare
szczys
approved these changes
Sep 22, 2022
Member
szczys
left a comment
szczys
left a comment
There was a problem hiding this comment.
The changes look good. I would suggest that you add to your commit message to indicate this matches the Zephyr naming convention change from zephyr.h to kernel.h
- zephyr.h is already deprecated, hence using kernel.h instead of it. - fix #47 - affects cores/ and variants/ dirs Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
DhruvaG2000
force-pushed
the
fix/include-build-warns
branch
from
ea681ae to
3a5430a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix #47
Signed-off-by: Dhruva Gole goledhruva@gmail.com