variants: Introduce the builtin-led-gpios node #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
builtin-led-gpios
branch
2 times, most recently
from
62d1863 to
e4be5a6
Compare
szczys
approved these changes
Oct 25, 2022
Member
szczys
left a comment
szczys
left a comment
There was a problem hiding this comment.
This is a nice improvement and the changes LGTM.
This PR should also include an update to the variant documentation on this topic: https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/blob/5c305c663a66cb8f74fc1f2d3a22eba0eb515694/documentation/variants.md?plain=1#L57-L84
Introduce the `builtin-led-gpios` node to make possible to configuring the builtin-led from dts. This node uses to determine the value of the `LED_BUILTIN` macro. Use the `led0` alias to determine the `LED_BUILTIN` if the `builtin-led-gpios` is not defined. The behavior can override by defining the `LED_BUILTIN` in pinmap.h. It uses definitions that are defined in the header preferentially. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Add a description for `builtin-led-gpios` Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
soburi
force-pushed
the
builtin-led-gpios
branch
from
e4be5a6 to
d5d53c6
Compare
Member
Author
|
Thank you for reviewing.
I update the document. |
DhruvaG2000
approved these changes
Nov 19, 2022
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
This makes the overall code around builtin LEDs much more generic and future proof. Great addition!
Tested-by: Dhruva Gole
soburi
pushed a commit
to soburi/gsoc-2022-arduino-core
that referenced
this pull request
Sep 24, 2025
…ins---variants.h Added legacy pin coverager for nano boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
builtin-led-gpiosnode to make possible to configuringthe builtin-led from dts.
This node uses to determine the value of the
LED_BUILTINmacro.Use the
led0alias to determine theLED_BUILTINif thebuiltin-led-gpiosis not defined.
The behavior can override by defining the
LED_BUILTINin pinmap.h.It uses definitions that are defined in the header preferentially.
The PR is contineued from #60.
I will rebase if #60 merged.