-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for nrf54l15dk/nrf54l15/cpuflpr #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
RRAM controller is used on the nRF54L series. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Space was missing before board name. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Tested manually, all tests are passing. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Ignore the build directory. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Tier 3 no-std targets that require building core and alloc from source. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
BOARD_TARGET is more specific about which core runs the sample. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Some targets need to be built with nightly and `-Z build-std=core,alloc`
It is possible to build for that target with nightly and standard library built from source.
Due to memory constraints, only samples built in release configuration can be enabled. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
0f4024b
to
c5877ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and thank you for this contribution. This should help us get more targets that don't use build configurations that exactly match one tier 1 or 2 of Rust.
I think there is still a rustfmt issue with one of the longer names, but I'm not seeing it locally.
samples/hello_world/src/lib.rs
Outdated
} | ||
|
||
info!("Hello world from Rust on {}", zephyr::kconfig::CONFIG_BOARD); | ||
info!("Hello world from Rust on {}", zephyr::kconfig::CONFIG_BOARD_TARGET); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to either format these manual, or just use cargo fmt
to reflow them. With the longer name, it breaks this across multiple lines.
The longer identifier for the board messages causes rustfmt to flow this onto multiple lines. Apply this change so that the check will pass during CI. Signed-off-by: David Brown <david.brown@linaro.org>
Depends on:
#128
#108