net: tcp: Fix out-of-bound warnings in debugging code #100035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few debug logs in TCP code relied on a fact that IP address offset is the same in struct sockaddr_in and sockaddr_in6. However, the logs casted the address to struct sockaddr_in, which is smaller than sockaddr_in6, causing theoretical out-of-bounds access warnings in IPv6 case. Fix this by casting to struct sockaddr_in6 instead. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
|
carlescufi
approved these changes
Nov 25, 2025
carlescufi
added
the
Trivial
pdgendt
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few debug logs in TCP code relied on a fact that IP address offset is the same in struct sockaddr_in and sockaddr_in6. However, the logs casted the address to struct sockaddr_in, which is smaller than sockaddr_in6, causing theoretical out-of-bounds access warnings in IPv6 case. Fix this by casting to struct sockaddr_in6 instead.
Fixes #99998