drivers: ethernet: phy: split generic phy #100454
Merged
+216
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ClaCodes,
Holt-Sun,
dbaluta,
decsny,
lmajewski,
manuargue,
mbolivar,
mmahadevan108,
pdgendt,
rruuaanng and
zejiang0jason
pdgendt
previously approved these changes
Dec 3, 2025
maass-hamburg
force-pushed
the
ethernet_phy_split
branch
from
748de92 to
11a8efb
Compare
Member
Author
|
Reassigned to me, because this is all just "internal" ethernet driver stuff |
pdgendt
previously approved these changes
Dec 3, 2025
Member
Author
|
unrelated ci fail due to #100426 |
mbolivar
requested changes
Dec 3, 2025
Comment on lines
9
to
18
| description: Reset pin. | ||
| Optional GPIO used to reset the PHY | ||
| reset-assert-duration-us: | ||
| type: int | ||
| description: | ||
| Minimum duration in microseconds to assert the reset-gpios pin. | ||
| reset-deassertion-timeout-ms: | ||
| type: int | ||
| description: | ||
| Timeout in milliseconds after the reset-gpios pin is deasserted. |
Contributor
There was a problem hiding this comment.
allow driver to be build without mdio, implemented similar to ptp. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
split and group common dts bindings Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
moves the fixed link functionality of the generic ethernet phy into its own driver. This makes both drivers more readable and efficient. Also makes it easier to use the normal generic phy as a base for a vendor specific driver, as the fixed link functionality is not needed on them. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Mention split of the ethernet phy. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
ethernet_phy_split
branch
from
11a8efb to
7e78718
Compare
mbolivar
approved these changes
Dec 3, 2025
|
pdgendt
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves the fixed link functionality of the
generic ethernet phy into its own driver.
This makes both drivers more readable and
efficient.
Also makes it easier to use the normal generic
phy as a base for a vendor specific driver, as
the fixed link functionality is not needed on
them.
CONFIG_MDIO is now also no longer needed for the
fixed link and therefore no longer selected.