sensor: current_amp: fix incorrect PM error #100486
Open
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning `-ENOTSUP` (and logging a `LOG_ERR`) is not the correct behaviour if there is no enable GPIO. The fact there was no work to do does not make the result an error. From the docs for `pm_device_runtime_get` ``` * @RetVal 0 If it succeeds. In case device runtime PM is not enabled or * not available this function will be a no-op and will also return 0. ``` Signed-off-by: Jordan Yates <jordan@embeint.com>
zephyrbot
requested review from
MaureenHelm,
asemjonovs,
avisconti,
jeppenodgaard,
teburd,
tristan-google,
ubieda and
yperess
|
MaureenHelm
approved these changes
Dec 4, 2025
jeppenodgaard
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
-ENOTSUP(and logging aLOG_ERR) is not the correct behaviour if there is no enable GPIO. The fact there was no work to do does not make the result an error.From the docs for
pm_device_runtime_get