Fix include path to app_version.h #100496
Open
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update include path note for app_version.h to match changes from PR zephyrproject-rtos#63973 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
zephyrbot
requested review from
57300,
carlescufi,
jakub-uC,
jeremybettis,
nashif,
nordicjm and
tejlmand
nordicjm
previously approved these changes
Dec 4, 2025
Contributor
nordicjm
left a comment
nordicjm
left a comment
There was a problem hiding this comment.
Compliance needs fixing but fix is OK. Other files can be updated also yes
Fix include of app_version.h (see PR zephyrproject-rtos#63973). Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix include of app_version.h (see PR zephyrproject-rtos#63973). Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix include of app_version.h (see PR zephyrproject-rtos#63973). Signed-off-by: Thomas Decker <decker@jb-lighting.de>
TD-JBL
force-pushed
the
app_version_include
branch
from
7d39cf6 to
b2fc4fe
Compare
zephyrbot
added
platform: Silabs
zephyrbot
requested review from
Martinhoff-maker,
asmellby,
jerome-pouiller and
jhedberg
|
nordicjm
approved these changes
Dec 4, 2025
asmellby
approved these changes
Dec 4, 2025
tejlmand
approved these changes
Dec 4, 2025
jhedberg
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
zephyr/namespace toapp_version.h-includes to match with the changes made in #63973:Fix #100458
I could also add commits to change the includes in
soc\silabs\silabs_s2\soc_image_properties.candtests\cmake\app_version\src\main.c, but I can't test it (but maybe CI does in this PR?)