Skip to content

boards: nxp: remove unused definitions #100649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZhaoxiangJin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

boards: nxp: remove unused definitions #100649

ZhaoxiangJin wants to merge 1 commit into from
+0 −4

Conversation

@ZhaoxiangJin
Copy link
Contributor

@ZhaoxiangJin ZhaoxiangJin commented Dec 8, 2025

  1. Remove 'XIP_BOOT_HEADER_ENABLE', it is not used in the mcxn947 build tree.
  2. Remove 'BOARD_FLASH_SIZE', it is not used in the rw612 build tree.

@ZhaoxiangJin
boards: nxp: remove unused definitions
8338dcc 
1. Remove 'XIP_BOOT_HEADER_ENABLE', it is not
used in the mcxn947 build tree.

2. Remove 'BOARD_FLASH_SIZE', it is not used
in the rw612 build tree.

Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
@ZhaoxiangJin ZhaoxiangJin marked this pull request as ready for review December 8, 2025 08:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@butok
Copy link
Contributor

butok commented Dec 8, 2025

The mcxn947 has on-board external flash. Can these definitions be used for this use case?

@ZhaoxiangJin
Copy link
Contributor Author

ZhaoxiangJin commented Dec 8, 2025

The mcxn947 has on-board external flash. Can these definitions be used for this use case?

As I know, BOOT MCXN947 from external flash does not need boot header. Add @mmahadevan108 and @DerekSnell for conformation.

@DerekSnell
Copy link
Contributor

DerekSnell commented Dec 8, 2025

The mcxn947 has on-board external flash. Can these definitions be used for this use case?

Hi @butok ,
We already confirmed this in another PR, see #100252 (comment) . The MCXN devices do not use the XIP_BOOT_HEADER_ENABLE flag.

But thanks for raising this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@butok butok butok approved these changes

@Holt-Sun Holt-Sun Holt-Sun approved these changes

@zejiang0jason zejiang0jason zejiang0jason approved these changes

@DerekSnell DerekSnell DerekSnell approved these changes

@axelnxp axelnxp Awaiting requested review from axelnxp

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@NeilChen93 NeilChen93 Awaiting requested review from NeilChen93

@hakehuang hakehuang Awaiting requested review from hakehuang

Assignees

@mmahadevan108 mmahadevan108

Labels

area: Boards/SoCs platform: NXP MCU platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZhaoxiangJin @butok @DerekSnell @Holt-Sun @zejiang0jason @mmahadevan108 @zephyrbot