drivers: sensor: adi: adxl345: take selected g-range into account when converting samples #100746
+25
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
asemjonovs,
avisconti,
galak,
jeppenodgaard,
microbuilder,
ozersa,
teburd,
tristan-google,
ttmut,
ubieda,
yasinustunerg and
yperess
stemschmidt
force-pushed
the
sensor_adxl345_channel_get
branch
from
e5b582b to
057ee44
Compare
MaureenHelm
reviewed
Dec 9, 2025
Member
MaureenHelm
left a comment
MaureenHelm
left a comment
There was a problem hiding this comment.
Thanks for the fix. The code changes look good, but the commit message needs to be updated to fix the compliance check:
1: UC5 Commit title exceeds max length (77>75): "drivers: sensor: adi: adxl345: take selected range into account in conversion"
11: UC4 Commit message body line exceeds max length (76>75): "adxl345_accel_convert is also made static as it is not used by another file."
057ee44 to
6c43105
Compare
When running the samples/sensor/accel_trig sample with a adxl345 sensor the logged output values were doubled compared to the expected values. The sensor_channel_get() path calls adxl345_accel_convert which did not handle the configured g-range, resulting in invalid sample values except for the +/-16g range. To fix this issue the configured range is taken into account and different conversion factors are applied. adxl345_accel_convert is also made static. It is not used by another file. Signed-off-by: Stefan Schmidt <kontakt@stefanschmidt-embedded.de>
stemschmidt
force-pushed
the
sensor_adxl345_channel_get
branch
from
291bf02 to
4612b6f
Compare
|
ubieda
approved these changes
Dec 9, 2025
MaureenHelm
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the samples/sensor/accel_trig sample with a adxl345 sensor the logged output values were doubled compared to the expected values.
The sensor_channel_get() path calls adxl345_accel_convert which did not handle the configured g-range, resulting in invalid sample values except for the +/-16g range. To fix this issue the configured range is taken into account and different conversion factors are applied.
adxl345_accel_convert is also made static as it is not used by another file.