SSD16xx implement read support #47757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysan
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
andysan
force-pushed
the
ssd16xx_read_for_upstream
branch
2 times, most recently
from
aa0802e to
6eecf01
Compare
andysan
force-pushed
the
ssd16xx_read_for_upstream
branch
from
6eecf01 to
8974c0c
Compare
jfischer-no
reviewed
Jul 18, 2022
jfischer-no
previously approved these changes
Jul 19, 2022
Contributor
Author
|
Ping. Can I get another review on these changes so we can merge them? |
andysan
force-pushed
the
ssd16xx_read_for_upstream
branch
3 times, most recently
from
08771f0 to
bb50cca
Compare
Read operations only work on SPI controllers that support half duplex. To enable read operations, set the device mode to half duplex by adding the following to the device's DTB node: duplex = <SPI_HALF_DUPLEX>; If read requests will fail with -ENOTSUP if the device isn't in half duplex mode. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
Add the ssd16xx_read_ram() function that can be used to read the raw contents of the two display RAM in the controller. This function is similar to display_read(), but lets the caller specify the RAM to operate on. The intention is that this can be used to read out the contents of the old frame buffer after a partial refresh that automatically swaps the black/red buffers. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
andysan
force-pushed
the
ssd16xx_read_for_upstream
branch
from
bb50cca to
93be3d2
Compare
mbolivar-nordic
approved these changes
Jul 25, 2022
Contributor
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
@jfischer-no I am approving only after skimming the changes quickly as all seems OK from a high level. Please approve if you believe the details are correct. I do not know this part.
jfischer-no
approved these changes
Jul 27, 2022
Contributor
Author
|
Can we make sure that #47712 is merged before this one? These two PRe will be conflicting and I think it would be much less pain for everyone involve if we resolve the conflicts on this smaller PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for basic read operations on the SSD16xx display controller. It consists of two commits:
display_readAPI.Read operations require the SPI bus to be in half duplex mode. To enable read operations, set the device mode to half duplex by adding the following to the device's DTB node:
If read requests will fail with -ENOTSUP if the device isn't in half duplex mode.
Tested on a couple of different SSD168x-basde displays using the SPI bit banging driver.
Update: Pushed a new version which moves the device-specific include from the first commit (incorrect) to the second commit. This fixes potential future bisection issues.
Update: Rebased on latest main.