Skip to content

Conversation

@savent404
Copy link
Contributor

@savent404 savent404 commented Apr 28, 2023

User can use 6-PWM motor driver in dts like this below:

	pwms =
		<&pwm 1 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch1
		<&pwm 2 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch2
		<&pwm 3 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch3
		<&pwm 1 PWM_USEC(50) (PWM_POLARITY_NORMAL | STM32_PWM_COMPLEMENTARY)>, // ch1n
		<&pwm 2 PWM_USEC(50) (PWM_POLARITY_NORMAL | STM32_PWM_COMPLEMENTARY)>, // ch2n
		<&pwm 3 PWM_USEC(50) (PWM_POLARITY_NORMAL | STM32_PWM_COMPLEMENTARY)>; // ch3n

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @savent404, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

@savent404 savent404 force-pushed the feat/stm32-6-pwm branch 7 times, most recently from b2cf0ec to 033e301 Compare April 28, 2023 12:49
User can use 6-PWM motor driver in dts like this below:
```dts
pwms =
 // ch1,ch2,ch3,ch1n,ch2n,ch3n
 <&pwm 1 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch1
 <&pwm 2 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch2
 <&pwm 3 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch3
 <&pwm 1 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>,
 <&pwm 2 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>,
 <&pwm 3 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>;
```

Signed-off-by: Savent Gate <savent_gate@outlook.com>
@savent404
Copy link
Contributor Author

@erwango review request

@erwango erwango assigned FRASTM and unassigned erwango May 2, 2023
@savent404
Copy link
Contributor Author

@FRASTM review plz

@savent404
Copy link
Contributor Author

@erwango @ABOSTM @GeorgeCGV @anangl @gautierg-st request view

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition.

While you're at, would you mind updating binding description ?

This would help others understanding what are the capabilities available so they can enjoy your work. One good example is https://github.com/zephyrproject-rtos/zephyr/blame/main/dts/bindings/pwm/espressif%2Cesp32-mcpwm.yaml#L4, but it doesn't have to be that long.

This is only a suggestion (which can also be done in another PR). Change is approved anyway.

@fabiobaltieri fabiobaltieri merged commit e2c3931 into zephyrproject-rtos:main May 15, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @savent404!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

savent404 added a commit to savent404/zephyr that referenced this pull request May 16, 2023
Since Merge zephyrproject-rtos#57360, user can use ch<x> and ch<x>N
simultaneously, which is beneficial for STM32 users
working in motor control area.

Signed-off-by: Savent Gate <savent_gate@outlook.com>
@savent404
Copy link
Contributor Author

Thanks for this addition.

While you're at, would you mind updating binding description ?

This would help others understanding what are the capabilities available so they can enjoy your work. One good example is https://github.com/zephyrproject-rtos/zephyr/blame/main/dts/bindings/pwm/espressif%2Cesp32-mcpwm.yaml#L4, but it doesn't have to be that long.

This is only a suggestion (which can also be done in another PR). Change is approved anyway.

started an another PR: #57913

@savent404 savent404 deleted the feat/stm32-6-pwm branch May 16, 2023 01:53
carlescufi pushed a commit that referenced this pull request May 22, 2023
Since Merge #57360, user can use ch<x> and ch<x>N
simultaneously, which is beneficial for STM32 users
working in motor control area.

Signed-off-by: Savent Gate <savent_gate@outlook.com>
qipengzha pushed a commit to qipengzha/zephyr that referenced this pull request May 24, 2023
Since Merge zephyrproject-rtos#57360, user can use ch<x> and ch<x>N
simultaneously, which is beneficial for STM32 users
working in motor control area.

Signed-off-by: Savent Gate <savent_gate@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: PWM Pulse Width Modulation platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants