-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: pwm: pwm_stm32: Add 6-PWM support #57360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: pwm: pwm_stm32: Add 6-PWM support #57360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @savent404, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
b2cf0ec to
033e301
Compare
User can use 6-PWM motor driver in dts like this below: ```dts pwms = // ch1,ch2,ch3,ch1n,ch2n,ch3n <&pwm 1 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch1 <&pwm 2 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch2 <&pwm 3 PWM_USEC(50) PWM_POLARITY_NORMAL>, // ch3 <&pwm 1 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>, <&pwm 2 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>, <&pwm 3 PWM_USEC(50) (PWM_POLARITY_NORMAL|STM32_PWM_COMPLEMENTARY)>; ``` Signed-off-by: Savent Gate <savent_gate@outlook.com>
033e301 to
648786a
Compare
|
@erwango review request |
|
@FRASTM review plz |
|
@erwango @ABOSTM @GeorgeCGV @anangl @gautierg-st request view |
erwango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition.
While you're at, would you mind updating binding description ?
This would help others understanding what are the capabilities available so they can enjoy your work. One good example is https://github.com/zephyrproject-rtos/zephyr/blame/main/dts/bindings/pwm/espressif%2Cesp32-mcpwm.yaml#L4, but it doesn't have to be that long.
This is only a suggestion (which can also be done in another PR). Change is approved anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @savent404!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
Since Merge zephyrproject-rtos#57360, user can use ch<x> and ch<x>N simultaneously, which is beneficial for STM32 users working in motor control area. Signed-off-by: Savent Gate <savent_gate@outlook.com>
started an another PR: #57913 |
Since Merge #57360, user can use ch<x> and ch<x>N simultaneously, which is beneficial for STM32 users working in motor control area. Signed-off-by: Savent Gate <savent_gate@outlook.com>
Since Merge zephyrproject-rtos#57360, user can use ch<x> and ch<x>N simultaneously, which is beneficial for STM32 users working in motor control area. Signed-off-by: Savent Gate <savent_gate@outlook.com>
User can use 6-PWM motor driver in dts like this below: