Bluetooth: tests: fix buf tests
#72135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete tests that did not end up bringing any value. What ended up happening is busy-work to "make the test pass" without understanding what's their original purpose. Worse, the CI change-based testing is broken and doesn't pick them up, even by PRs modifying the tests themeselves. See zephyrproject-rtos#68008 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
Thalley,
alwa-nordic,
hermabe,
jhedberg,
sjanc and
theob-pro
theob-pro
approved these changes
Apr 30, 2024
Contributor
|
I guess the author @ahmedmoheb-nordic isn't active anymore? |
Contributor
Author
|
he isn't no. And @alwa-nordic is going to mess with |
jori-nordic
added
the
Hotfix
Contributor
Author
|
I added the |
alwa-nordic
approved these changes
Apr 30, 2024
Thalley
approved these changes
Apr 30, 2024
LingaoM
added a commit
that referenced
this pull request
Jun 25, 2024
After #72135 there are no-used at all, so deleted. Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete tests that did not end up bringing any value.
What ended up happening is busy-work to "make the test pass" without understanding what's their original purpose.
Worse, the CI change-based testing is broken and doesn't pick them up, even by PRs modifying the tests themeselves.
See #68008