-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: adc: esp32: dma enable #73228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e4ba3e9 to
3e223fd
Compare
uLipe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some nitpicks, otherwise, looks great!
adc dma mode operation on ESP32S3 and ESP32C3 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
adds test case for esp32 adc with dma enabled Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
|
@anangl could you please take a look? |
anangl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tests: drivers: adc" is not a very informative commit title
|
|
||
| config ADC_ESP32_DMA | ||
| bool "ESP32 ADC DMA Support" | ||
| default n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default n is redundant.
adc dma operation mode on ESP32S3 and ESP32C3