Skip to content

Conversation

@wmrsouza
Copy link
Contributor

@wmrsouza wmrsouza commented May 23, 2024

adc dma operation mode on ESP32S3 and ESP32C3

@wmrsouza wmrsouza force-pushed the feature/adc_dma branch 7 times, most recently from e4ba3e9 to 3e223fd Compare May 27, 2024 20:01
@wmrsouza wmrsouza marked this pull request as ready for review May 28, 2024 18:33
@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) platform: ESP32 Espressif ESP32 labels May 28, 2024
uLipe
uLipe previously approved these changes May 28, 2024
Copy link
Member

@uLipe uLipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some nitpicks, otherwise, looks great!

@wmrsouza wmrsouza requested a review from uLipe June 3, 2024 19:30
wmrsouza added 2 commits June 5, 2024 10:26
adc dma mode operation on ESP32S3 and ESP32C3

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
adds test case for esp32 adc with dma enabled

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
@sylvioalves sylvioalves requested review from carlescufi and nashif June 10, 2024 12:46
@wmrsouza
Copy link
Contributor Author

@anangl could you please take a look?

Copy link
Member

@anangl anangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tests: drivers: adc" is not a very informative commit title


config ADC_ESP32_DMA
bool "ESP32 ADC DMA Support"
default n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default n is redundant.

@carlescufi carlescufi merged commit 86ff968 into zephyrproject-rtos:main Jun 10, 2024
@wmrsouza wmrsouza deleted the feature/adc_dma branch August 27, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC) platform: ESP32 Espressif ESP32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants