refactoring of scanner state machine #73923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tschet1
changed the title
Tschet1
force-pushed
the
concurrent_init_scan
branch
12 times, most recently
from
a3f6b94 to
4c1daed
Compare
Tschet1
changed the title
zephyrbot
added
platform: nRF BSIM
zephyrbot
requested review from
Thalley,
aescolar,
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc and
theob-pro
jhedberg
reviewed
Jun 14, 2024
Tschet1
force-pushed
the
concurrent_init_scan
branch
from
4c1daed to
c7059f7
Compare
Tschet1
added a commit
to Tschet1/sdk-zephyr
that referenced
this pull request
Jul 16, 2024
To make the scanner module more understandable and more streamlined, I reworked the update mechanism of the scanner. The scanner tracks now the parameters that were used to enable it and the reason why it is running. This facilitates state logic and allows other modules to "start the scanner", altough it is already running. This is mostly a refactoring and not a functional change. Added a test to verify the behavior. Upstream PR: zephyrproject-rtos/zephyr#73923 Signed-off-by: Jan Müller <jan.mueller@nordicsemi.no>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 16, 2024
To make the scanner module more understandable and more streamlined, I reworked the update mechanism of the scanner. The scanner tracks now the parameters that were used to enable it and the reason why it is running. This facilitates state logic and allows other modules to "start the scanner", altough it is already running. This is mostly a refactoring and not a functional change. Added a test to verify the behavior. Upstream PR: zephyrproject-rtos/zephyr#73923 Signed-off-by: Jan Müller <jan.mueller@nordicsemi.no>
Member
|
merge conflict, can you rebase please? |
Member
|
@Tschet1 this needs a rebase |
Member
|
rebase please |
Tschet1
dismissed stale reviews from jhedberg, jori-nordic, and Thalley
via
5c2d7f3
Tschet1
force-pushed
the
concurrent_init_scan
branch
from
eaff5ed to
5c2d7f3
Compare
Contributor
Author
|
sorry was on holidays. Rebased now. |
jori-nordic
previously approved these changes
Aug 20, 2024
To make the scanner module more understandable and more streamlined, I reworked the update mechanism of the scanner. The scanner tracks now the parameters that were used to enable it and the reason why it is running. This facilitates state logic and allows other modules to "start the scanner", altough it is already running. This is mostly a refactoring and not a functional change. Added a test to verify the behavior. Signed-off-by: Jan Müller <jan.mueller@nordicsemi.no> add to task
Tschet1
force-pushed
the
concurrent_init_scan
branch
from
5c2d7f3 to
132bce1
Compare
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Aug 20, 2024
To make the scanner module more understandable and more streamlined, I reworked the update mechanism of the scanner. The scanner tracks now the parameters that were used to enable it and the reason why it is running. This facilitates state logic and allows other modules to "start the scanner", altough it is already running. This is mostly a refactoring and not a functional change. Added a test to verify the behavior. Upstream PR: zephyrproject-rtos/zephyr#73923 Signed-off-by: Jan Müller <jan.mueller@nordicsemi.no>
jori-nordic
approved these changes
Aug 20, 2024
Thalley
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework enabling of scanner
To make the scanner module more understandable and more streamlined, I
reworked the update mechanism of the scanner. The scanner tracks now the
parameters that were used to enable it and the reason why it is running.
This facilitates state logic and allows other modules to "start the
scanner", altough it is already running.