Skip to content

Conversation

kartben
Copy link
Contributor

@kartben kartben commented Jun 27, 2024

As of recent update of stm32f7 HAL to cube version V1.17.2 the workaround for misspelled HAL_ETH_PTP_CONFIGURATED macro is not needed anymore, and causes PTP support to fail to compile.

See https://github.com/zephyrproject-rtos/hal_stm32/blame/855f195793df094644ce8b8617c01275408bbf58/stm32cube/stm32f7xx/drivers/include/stm32f7xx_hal_eth.h#L1696

cc @marwaiehm-st

As of recent update of stm32f7 HAL to cube version V1.17.2
the workaround for misspelled HAL_ETH_PTP_CONFIGURATED macro
is not needed anymore, and causes PTP support to fail to compile.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben added this to the v3.7.0 milestone Jun 27, 2024
@kartben kartben added the bug The issue is a bug, or the PR is fixing a bug label Jun 27, 2024
@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code area: Ethernet labels Jun 27, 2024
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kartben

@kartben
Copy link
Contributor Author

kartben commented Jun 27, 2024

@erwango There is more needed to fix PTP on F7 - I just opened zephyrproject-rtos/hal_stm32#220

@nashif nashif merged commit f19446f into zephyrproject-rtos:main Jul 1, 2024
@kartben kartben deleted the stm32f7ptp branch July 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Ethernet bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants