boards: nordic: nrf9160dk: Correct board check for nrf52840_reset #76294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With HWMv2 CONFIG_BOARD_NRF9160DK_NRF9160 is not defined when building the non-secure target, so it has to be specified. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
zephyrbot
added
size: XS
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordicjm
approved these changes
Jul 25, 2024
lemrey
approved these changes
Jul 26, 2024
anangl
approved these changes
Jul 26, 2024
jaz1-nordic
approved these changes
Jul 26, 2024
fabiobaltieri
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HWMv2 CONFIG_BOARD_NRF9160DK_NRF9160 is not defined when building the non-secure target, so it has to be specified.